From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1048 invoked by alias); 2 Aug 2004 18:39:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1040 invoked from network); 2 Aug 2004 18:39:14 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 2 Aug 2004 18:39:14 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i72IdEe3007180 for ; Mon, 2 Aug 2004 14:39:14 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i72IdEa28390; Mon, 2 Aug 2004 14:39:14 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B3ED02B9D; Mon, 2 Aug 2004 14:39:07 -0400 (EDT) Message-ID: <410E8A4B.9080902@gnu.org> Date: Mon, 02 Aug 2004 18:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801 MIME-Version: 1.0 To: cgd@broadcom.com Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Split MIPS unwinder three ways; partly References: <410D4198.3040908@gnu.org> <410E6B28.5080908@gnu.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00039.txt.bz2 > At Mon, 2 Aug 2004 16:26:47 +0000 (UTC), "Andrew Cagney" wrote: > >>> True. mips_isa32? > > > That may be *worse*, since mipsisa32 == "MIPS32" in bfd-speak. > > I don't know that it's important to make the names perfect, since this > is internal implementation and isn't exposed. > > But in that case it should be documented that it refers to "mips ISAs > with 32-bit instructions" (i.e., all but MIPS16). I'd rather have the code clearly scream its intent: mips_insn32_ mips_insn16_ ? (otherwize in a few months we'll have someone unintentionally trying to sneak code that handles 16-bit instruction into a 32-bit instruction function). Andrew