* Re: [RFA]: Fix jmisc testscases to recognize constructor
@ 2004-07-07 19:03 Michael Elizabeth Chastain
2004-07-07 19:22 ` Andrew Cagney
0 siblings, 1 reply; 5+ messages in thread
From: Michael Elizabeth Chastain @ 2004-07-07 19:03 UTC (permalink / raw)
To: gdb-patches, jjohnstn
Hmmm. Anthony Green is the maintainer for gdb.java, but he's been
inactive for a while. Anthony said that Andrew can commit patches
for gdb.java. IMHO that means Andrew is the guy for gdb.java
patch review at the moment.
Andrew, would you like to talk about updating the maintainers for
gdb.java ?
Meanwhile on this specific patch:
- please add copyright years 2004 to the files that you touch
- how did you test it (what system, what version of java)?
With those two things the patch looks good to me,
but I don't have approval authority in testsuite/gdb.java.
Michael C
===
2004-07-07 Jeff Johnston <jjohnstn@redhat.com>
* gdb.java/jmisc.exp: Fix expected output of ptype to look for
the jmisc() constructor instead of <init>.
* gdb.java/jmisc1.exp: Ditto.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [RFA]: Fix jmisc testscases to recognize constructor
2004-07-07 19:03 [RFA]: Fix jmisc testscases to recognize constructor Michael Elizabeth Chastain
@ 2004-07-07 19:22 ` Andrew Cagney
2004-07-07 19:52 ` Jeff Johnston
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Cagney @ 2004-07-07 19:22 UTC (permalink / raw)
To: Michael Elizabeth Chastain; +Cc: gdb-patches, jjohnstn
> Hmmm. Anthony Green is the maintainer for gdb.java, but he's been
> inactive for a while. Anthony said that Andrew can commit patches
> for gdb.java. IMHO that means Andrew is the guy for gdb.java
> patch review at the moment.
>
> Andrew, would you like to talk about updating the maintainers for
> gdb.java ?
>
> Meanwhile on this specific patch:
>
> - please add copyright years 2004 to the files that you touch
> - how did you test it (what system, what version of java)?
>
> With those two things the patch looks good to me,
> but I don't have approval authority in testsuite/gdb.java.
With that, ok.
> 2004-07-07 Jeff Johnston <jjohnstn@redhat.com>
>
> * gdb.java/jmisc.exp: Fix expected output of ptype to look for
> the jmisc() constructor instead of <init>.
> * gdb.java/jmisc1.exp: Ditto.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA]: Fix jmisc testscases to recognize constructor
2004-07-07 19:22 ` Andrew Cagney
@ 2004-07-07 19:52 ` Jeff Johnston
2004-07-07 20:09 ` Jeff Johnston
0 siblings, 1 reply; 5+ messages in thread
From: Jeff Johnston @ 2004-07-07 19:52 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Michael Elizabeth Chastain, gdb-patches
Andrew Cagney wrote:
>> Hmmm. Anthony Green is the maintainer for gdb.java, but he's been
>> inactive for a while. Anthony said that Andrew can commit patches
>> for gdb.java. IMHO that means Andrew is the guy for gdb.java
>> patch review at the moment.
>>
>> Andrew, would you like to talk about updating the maintainers for
>> gdb.java ?
>>
>> Meanwhile on this specific patch:
>>
>> - please add copyright years 2004 to the files that you touch
Sorry. Done.
>> - how did you test it (what system, what version of java)?
>>
Tested on x86 RHEL3 with gcc 3.4.0 and gcc mainline (3.5).
>> With those two things the patch looks good to me,
>> but I don't have approval authority in testsuite/gdb.java.
>
>
> With that, ok.
>
>> 2004-07-07 Jeff Johnston <jjohnstn@redhat.com>
>>
>> * gdb.java/jmisc.exp: Fix expected output of ptype to look for
>> the jmisc() constructor instead of <init>.
>> * gdb.java/jmisc1.exp: Ditto.
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA]: Fix jmisc testscases to recognize constructor
2004-07-07 19:52 ` Jeff Johnston
@ 2004-07-07 20:09 ` Jeff Johnston
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Johnston @ 2004-07-07 20:09 UTC (permalink / raw)
To: Jeff Johnston; +Cc: Andrew Cagney, Michael Elizabeth Chastain, gdb-patches
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
Attached patch checked in (has copyright updates).
-- Jeff J.
Jeff Johnston wrote:
> Andrew Cagney wrote:
>
>>> Hmmm. Anthony Green is the maintainer for gdb.java, but he's been
>>> inactive for a while. Anthony said that Andrew can commit patches
>>> for gdb.java. IMHO that means Andrew is the guy for gdb.java
>>> patch review at the moment.
>>>
>>> Andrew, would you like to talk about updating the maintainers for
>>> gdb.java ?
>>>
>>> Meanwhile on this specific patch:
>>>
>>> - please add copyright years 2004 to the files that you touch
>
>
> Sorry. Done.
>
>>> - how did you test it (what system, what version of java)?
>>>
>
> Tested on x86 RHEL3 with gcc 3.4.0 and gcc mainline (3.5).
>
>>> With those two things the patch looks good to me,
>>> but I don't have approval authority in testsuite/gdb.java.
>>
>>
>>
>> With that, ok.
>>
>>> 2004-07-07 Jeff Johnston <jjohnstn@redhat.com>
>>>
>>> * gdb.java/jmisc.exp: Fix expected output of ptype to look for
>>> the jmisc() constructor instead of <init>.
>>> * gdb.java/jmisc1.exp: Ditto.
>>
>>
>>
>>
>>
>
>
[-- Attachment #2: java-test.patch --]
[-- Type: text/plain, Size: 2447 bytes --]
Index: gdb.java/jmisc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmisc.exp,v
retrieving revision 1.3
diff -u -p -r1.3 jmisc.exp
--- gdb.java/jmisc.exp 24 Feb 2004 16:09:48 -0000 1.3
+++ gdb.java/jmisc.exp 7 Jul 2004 20:07:12 -0000
@@ -1,4 +1,4 @@
-# Copyright 2000 Free Software Foundation, Inc.
+# Copyright 2000, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -72,7 +72,7 @@ if ![set_lang_java] then {
send_gdb "ptype jmisc\n"
gdb_expect {
- -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+void <init>\\(void\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
+ -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
-re ".*$gdb_prompt $" { fail "ptype jmisc" }
timeout { fail "ptype jmisc (timeout)" ; return }
}
Index: gdb.java/jmisc1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmisc1.exp,v
retrieving revision 1.2
diff -u -p -r1.2 jmisc1.exp
--- gdb.java/jmisc1.exp 14 Aug 2003 19:11:10 -0000 1.2
+++ gdb.java/jmisc1.exp 7 Jul 2004 20:07:12 -0000
@@ -1,4 +1,4 @@
-# Copyright 2002, 2003 Free Software Foundation, Inc.
+# Copyright 2002, 2003, 2004 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -70,7 +70,7 @@ if ![set_lang_java] then {
send_gdb "ptype jmisc\n"
gdb_expect {
- -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+void <init>\\(void\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
+ -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
-re ".*$gdb_prompt $" { fail "ptype jmisc" }
timeout { fail "ptype jmisc (timeout)" ; return }
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFA]: Fix jmisc testscases to recognize constructor
@ 2004-07-07 15:48 Jeff Johnston
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Johnston @ 2004-07-07 15:48 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
The attached patch fixes two failures in gdb.java whereby gdb is reporting the
constructor in the ptype and the testcase is expecting to see <init>.
Ok to commit?
2004-07-07 Jeff Johnston <jjohnstn@redhat.com>
* gdb.java/jmisc.exp: Fix expected output of ptype to look for
the jmisc() constructor instead of <init>.
* gdb.java/jmisc1.exp: Ditto.
[-- Attachment #2: java-test.patch --]
[-- Type: text/plain, Size: 1903 bytes --]
Index: gdb.java/jmisc.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmisc.exp,v
retrieving revision 1.3
diff -u -p -r1.3 jmisc.exp
--- gdb.java/jmisc.exp 24 Feb 2004 16:09:48 -0000 1.3
+++ gdb.java/jmisc.exp 7 Jul 2004 15:44:07 -0000
@@ -72,7 +72,7 @@ if ![set_lang_java] then {
send_gdb "ptype jmisc\n"
gdb_expect {
- -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+void <init>\\(void\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
+ -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
-re ".*$gdb_prompt $" { fail "ptype jmisc" }
timeout { fail "ptype jmisc (timeout)" ; return }
}
Index: gdb.java/jmisc1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmisc1.exp,v
retrieving revision 1.2
diff -u -p -r1.2 jmisc1.exp
--- gdb.java/jmisc1.exp 14 Aug 2003 19:11:10 -0000 1.2
+++ gdb.java/jmisc1.exp 7 Jul 2004 15:44:07 -0000
@@ -70,7 +70,7 @@ if ![set_lang_java] then {
send_gdb "ptype jmisc\n"
gdb_expect {
- -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+void <init>\\(void\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
+ -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" }
-re ".*$gdb_prompt $" { fail "ptype jmisc" }
timeout { fail "ptype jmisc (timeout)" ; return }
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-07-07 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-07 19:03 [RFA]: Fix jmisc testscases to recognize constructor Michael Elizabeth Chastain
2004-07-07 19:22 ` Andrew Cagney
2004-07-07 19:52 ` Jeff Johnston
2004-07-07 20:09 ` Jeff Johnston
-- strict thread matches above, loose matches on Subject: below --
2004-07-07 15:48 Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox