Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jeff Johnston <jjohnstn@redhat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: Michael Elizabeth Chastain <mec.gnu@mindspring.com>,
	gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Fix jmisc testscases to recognize constructor
Date: Wed, 07 Jul 2004 19:52:00 -0000	[thread overview]
Message-ID: <40EC545D.5030607@redhat.com> (raw)
In-Reply-To: <40EC4D6F.4070807@gnu.org>

Andrew Cagney wrote:
>> Hmmm.  Anthony Green is the maintainer for gdb.java, but he's been
>> inactive for a while.  Anthony said that Andrew can commit patches
>> for gdb.java.  IMHO that means Andrew is the guy for gdb.java
>> patch review at the moment.
>>
>> Andrew, would you like to talk about updating the maintainers for
>> gdb.java ?
>>
>> Meanwhile on this specific patch:
>>
>> - please add copyright years 2004 to the files that you touch

Sorry.  Done.

>> - how did you test it (what system, what version of java)?
>>

Tested on x86 RHEL3 with gcc 3.4.0 and gcc mainline (3.5).

>> With those two things the patch looks good to me,
>> but I don't have approval authority in testsuite/gdb.java.
> 
> 
> With that, ok.
> 
>> 2004-07-07  Jeff Johnston  <jjohnstn@redhat.com>
>>
>>          * gdb.java/jmisc.exp: Fix expected output of ptype to look for
>>          the jmisc() constructor instead of <init>.
>>          * gdb.java/jmisc1.exp: Ditto.
> 
> 
> 
> 


  reply	other threads:[~2004-07-07 19:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-07 19:03 Michael Elizabeth Chastain
2004-07-07 19:22 ` Andrew Cagney
2004-07-07 19:52   ` Jeff Johnston [this message]
2004-07-07 20:09     ` Jeff Johnston
  -- strict thread matches above, loose matches on Subject: below --
2004-07-07 15:48 Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40EC545D.5030607@redhat.com \
    --to=jjohnstn@redhat.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox