From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30243 invoked by alias); 7 Jul 2004 20:09:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30233 invoked from network); 7 Jul 2004 20:09:24 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Jul 2004 20:09:24 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i67K9Oe1008188 for ; Wed, 7 Jul 2004 16:09:24 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i67K9N032717; Wed, 7 Jul 2004 16:09:23 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i67K9NvU027703; Wed, 7 Jul 2004 16:09:23 -0400 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id C40748003D4; Wed, 7 Jul 2004 16:09:22 -0400 (EDT) Message-ID: <40EC5872.3090607@redhat.com> Date: Wed, 07 Jul 2004 20:09:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Jeff Johnston Cc: Andrew Cagney , Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix jmisc testscases to recognize constructor References: <20040707190317.EDACF4B104@berman.michael-chastain.com> <40EC4D6F.4070807@gnu.org> <40EC545D.5030607@redhat.com> In-Reply-To: <40EC545D.5030607@redhat.com> Content-Type: multipart/mixed; boundary="------------030904020907050106000905" X-SW-Source: 2004-07/txt/msg00068.txt.bz2 This is a multi-part message in MIME format. --------------030904020907050106000905 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1111 Attached patch checked in (has copyright updates). -- Jeff J. Jeff Johnston wrote: > Andrew Cagney wrote: > >>> Hmmm. Anthony Green is the maintainer for gdb.java, but he's been >>> inactive for a while. Anthony said that Andrew can commit patches >>> for gdb.java. IMHO that means Andrew is the guy for gdb.java >>> patch review at the moment. >>> >>> Andrew, would you like to talk about updating the maintainers for >>> gdb.java ? >>> >>> Meanwhile on this specific patch: >>> >>> - please add copyright years 2004 to the files that you touch > > > Sorry. Done. > >>> - how did you test it (what system, what version of java)? >>> > > Tested on x86 RHEL3 with gcc 3.4.0 and gcc mainline (3.5). > >>> With those two things the patch looks good to me, >>> but I don't have approval authority in testsuite/gdb.java. >> >> >> >> With that, ok. >> >>> 2004-07-07 Jeff Johnston >>> >>> * gdb.java/jmisc.exp: Fix expected output of ptype to look for >>> the jmisc() constructor instead of . >>> * gdb.java/jmisc1.exp: Ditto. >> >> >> >> >> > > --------------030904020907050106000905 Content-Type: text/plain; name="java-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="java-test.patch" Content-length: 2447 Index: gdb.java/jmisc.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmisc.exp,v retrieving revision 1.3 diff -u -p -r1.3 jmisc.exp --- gdb.java/jmisc.exp 24 Feb 2004 16:09:48 -0000 1.3 +++ gdb.java/jmisc.exp 7 Jul 2004 20:07:12 -0000 @@ -1,4 +1,4 @@ -# Copyright 2000 Free Software Foundation, Inc. +# Copyright 2000, 2004 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -72,7 +72,7 @@ if ![set_lang_java] then { send_gdb "ptype jmisc\n" gdb_expect { - -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+void \\(void\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" } + -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" } -re ".*$gdb_prompt $" { fail "ptype jmisc" } timeout { fail "ptype jmisc (timeout)" ; return } } Index: gdb.java/jmisc1.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmisc1.exp,v retrieving revision 1.2 diff -u -p -r1.2 jmisc1.exp --- gdb.java/jmisc1.exp 14 Aug 2003 19:11:10 -0000 1.2 +++ gdb.java/jmisc1.exp 7 Jul 2004 20:07:12 -0000 @@ -1,4 +1,4 @@ -# Copyright 2002, 2003 Free Software Foundation, Inc. +# Copyright 2002, 2003, 2004 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -70,7 +70,7 @@ if ![set_lang_java] then { send_gdb "ptype jmisc\n" gdb_expect { - -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+void \\(void\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" } + -re "type = class jmisc extends java.lang.Object \{\[\r\n\ \t]+void main\\(java\.lang\.String\\\[]\\);\[\r\n\ \t]+jmisc\\(\\);\[\r\n\ \t]+\}\[\r\n\ \t]+$gdb_prompt $" { pass "ptype jmisc" } -re ".*$gdb_prompt $" { fail "ptype jmisc" } timeout { fail "ptype jmisc (timeout)" ; return } } --------------030904020907050106000905--