[patch/rfc] Eliminate an IN_SIGTRAMP call from infrun.c

[patch/rfc] Eliminate an IN_SIGTRAMP call from infrun.c

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Hello,

Another bit of infrun becomes untangled.  check_sigtramp2 is trying to 
handle the case of a signal while nexting over a function call (it 
resumes the inferior letting the signal handler return).  The code 
includes checks using:

DEPRECATED_PC_IN_SIGTRAMP: For up-to-date architectures, it's always false.
INNER_THAN: Per sigaltstack discussion, useless test.

This patch removes those dead tests.

Baring comment, I'll commit this in a day or so.

Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1053 bytes --]

2004-04-30  Andrew Cagney  <cagney@redhat.com>

	* infrun.c (check_sigtramp2): Delete check for
	DEPRECATED_PC_IN_SIGTRAMP and INNER_THAN.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.150
diff -p -u -r1.150 infrun.c
--- infrun.c	29 Apr 2004 22:36:24 -0000	1.150
+++ infrun.c	30 Apr 2004 23:04:20 -0000
@@ -2715,14 +2715,6 @@ check_sigtramp2 (struct execution_contro
     return;
   if (get_frame_type (get_current_frame ()) != SIGTRAMP_FRAME)
     return;
-  /* Long term, this function can be eliminated, replaced by the code:
-     get_frame_type(current_frame()) == SIGTRAMP_FRAME (for new
-     architectures this is very cheap).  */
-  find_pc_partial_function (prev_pc, &name, NULL, NULL);
-  if (DEPRECATED_PC_IN_SIGTRAMP (prev_pc, name))
-    return;
-  if (!INNER_THAN (read_sp (), step_sp))
-    return;
 
   /* So we need to set a step_resume_break_address breakpoint and
      continue until we hit it, and then step.  FIXME: This should be

Re: [patch/rfc] Eliminate an IN_SIGTRAMP call from infrun.c

[Andrew Cagney]

> Hello,
> 
> Another bit of infrun becomes untangled.  check_sigtramp2 is trying to handle the case of a signal while nexting over a function call (it resumes the inferior letting the signal handler return).  The code includes checks using:
> 
> DEPRECATED_PC_IN_SIGTRAMP: For up-to-date architectures, it's always false.
> INNER_THAN: Per sigaltstack discussion, useless test.
> 
> This patch removes those dead tests.

I've checked this in.

> 2004-04-30  Andrew Cagney  <cagney@redhat.com>
> 
> 	* infrun.c (check_sigtramp2): Delete check for
> 	DEPRECATED_PC_IN_SIGTRAMP and INNER_THAN.

Andrew