From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22128 invoked by alias); 30 Apr 2004 23:15:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22115 invoked from network); 30 Apr 2004 23:15:52 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 30 Apr 2004 23:15:52 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3UNFpKI029920 for ; Fri, 30 Apr 2004 19:15:51 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3UNFpv09590; Fri, 30 Apr 2004 19:15:51 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2DB442B9D; Fri, 30 Apr 2004 19:15:53 -0400 (EDT) Message-ID: <4092DE29.6050805@gnu.org> Date: Fri, 30 Apr 2004 23:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [patch/rfc] Eliminate an IN_SIGTRAMP call from infrun.c Content-Type: multipart/mixed; boundary="------------040302090007020104010405" X-SW-Source: 2004-04/txt/msg00725.txt.bz2 This is a multi-part message in MIME format. --------------040302090007020104010405 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 466 Hello, Another bit of infrun becomes untangled. check_sigtramp2 is trying to handle the case of a signal while nexting over a function call (it resumes the inferior letting the signal handler return). The code includes checks using: DEPRECATED_PC_IN_SIGTRAMP: For up-to-date architectures, it's always false. INNER_THAN: Per sigaltstack discussion, useless test. This patch removes those dead tests. Baring comment, I'll commit this in a day or so. Andrew --------------040302090007020104010405 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 1053 2004-04-30 Andrew Cagney * infrun.c (check_sigtramp2): Delete check for DEPRECATED_PC_IN_SIGTRAMP and INNER_THAN. Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.150 diff -p -u -r1.150 infrun.c --- infrun.c 29 Apr 2004 22:36:24 -0000 1.150 +++ infrun.c 30 Apr 2004 23:04:20 -0000 @@ -2715,14 +2715,6 @@ check_sigtramp2 (struct execution_contro return; if (get_frame_type (get_current_frame ()) != SIGTRAMP_FRAME) return; - /* Long term, this function can be eliminated, replaced by the code: - get_frame_type(current_frame()) == SIGTRAMP_FRAME (for new - architectures this is very cheap). */ - find_pc_partial_function (prev_pc, &name, NULL, NULL); - if (DEPRECATED_PC_IN_SIGTRAMP (prev_pc, name)) - return; - if (!INNER_THAN (read_sp (), step_sp)) - return; /* So we need to set a step_resume_break_address breakpoint and continue until we hit it, and then step. FIXME: This should be --------------040302090007020104010405--