From: Andrew Cagney <cagney@gnu.org>
To: gdb-patches@sources.redhat.com
Subject: [patch/rfc] Eliminate an IN_SIGTRAMP call from infrun.c
Date: Fri, 30 Apr 2004 23:15:00 -0000 [thread overview]
Message-ID: <4092DE29.6050805@gnu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 466 bytes --]
Hello,
Another bit of infrun becomes untangled. check_sigtramp2 is trying to
handle the case of a signal while nexting over a function call (it
resumes the inferior letting the signal handler return). The code
includes checks using:
DEPRECATED_PC_IN_SIGTRAMP: For up-to-date architectures, it's always false.
INNER_THAN: Per sigaltstack discussion, useless test.
This patch removes those dead tests.
Baring comment, I'll commit this in a day or so.
Andrew
[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1053 bytes --]
2004-04-30 Andrew Cagney <cagney@redhat.com>
* infrun.c (check_sigtramp2): Delete check for
DEPRECATED_PC_IN_SIGTRAMP and INNER_THAN.
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.150
diff -p -u -r1.150 infrun.c
--- infrun.c 29 Apr 2004 22:36:24 -0000 1.150
+++ infrun.c 30 Apr 2004 23:04:20 -0000
@@ -2715,14 +2715,6 @@ check_sigtramp2 (struct execution_contro
return;
if (get_frame_type (get_current_frame ()) != SIGTRAMP_FRAME)
return;
- /* Long term, this function can be eliminated, replaced by the code:
- get_frame_type(current_frame()) == SIGTRAMP_FRAME (for new
- architectures this is very cheap). */
- find_pc_partial_function (prev_pc, &name, NULL, NULL);
- if (DEPRECATED_PC_IN_SIGTRAMP (prev_pc, name))
- return;
- if (!INNER_THAN (read_sp (), step_sp))
- return;
/* So we need to set a step_resume_break_address breakpoint and
continue until we hit it, and then step. FIXME: This should be
next reply other threads:[~2004-04-30 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-30 23:15 Andrew Cagney [this message]
2004-05-01 14:14 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4092DE29.6050805@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox