From: Andrew Cagney <cagney@gnu.org>
To: Orjan Friberg <orjan.friberg@axis.com>,
Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Multiplexed registers and invalidating the register cache
Date: Sat, 24 Apr 2004 00:03:00 -0000 [thread overview]
Message-ID: <4089636D.2090605@gnu.org> (raw)
In-Reply-To: <40893437.2020907@axis.com>
> +The target's register contents has changed.
FYI, this should probably read:
The target's memory or register contents have [has?] changed.
eli?
> +@deftypefun void target_changed (struct target_ops *@var{current_target})
- As a parameter, I'd just use "target" (you've current_target as a
parameter in several places) (one day there will be more than one target
...).
> +#include "observer.h"
- you'll want to update Makefile.in
Otherwize assuming, eli's ok with the fixed wording, its ok to commit.
Andrew
next prev parent reply other threads:[~2004-04-24 0:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 11:44 Orjan Friberg
2004-04-14 14:46 ` Daniel Jacobowitz
2004-04-14 16:01 ` Andrew Cagney
2004-04-15 10:46 ` Orjan Friberg
2004-04-15 11:25 ` Orjan Friberg
2004-04-15 15:29 ` Andrew Cagney
2004-04-16 12:51 ` Orjan Friberg
2004-04-16 14:13 ` Daniel Jacobowitz
2004-04-16 14:54 ` Orjan Friberg
2004-04-16 19:15 ` Andrew Cagney
2004-04-19 14:13 ` Orjan Friberg
2004-04-21 16:48 ` Andrew Cagney
2004-04-22 13:58 ` Orjan Friberg
2004-04-22 14:33 ` Andrew Cagney
2004-04-23 11:25 ` Orjan Friberg
2004-04-24 0:03 ` Andrew Cagney
2004-04-23 15:20 ` Orjan Friberg
2004-04-23 17:58 ` Eli Zaretskii
2004-04-26 9:41 ` Orjan Friberg
2004-04-24 0:03 ` Andrew Cagney [this message]
2004-04-24 8:30 ` Eli Zaretskii
2004-04-28 16:43 ` Andrew Cagney
2004-04-28 17:40 ` Eli Zaretskii
2004-04-29 8:09 ` Orjan Friberg
2004-04-29 17:56 ` Eli Zaretskii
2004-04-30 7:39 ` Orjan Friberg
2004-04-26 9:50 ` Orjan Friberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4089636D.2090605@gnu.org \
--to=cagney@gnu.org \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=orjan.friberg@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox