From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-32572-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 3927 invoked by alias); 24 Apr 2004 00:03:07 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 3799 invoked from network); 24 Apr 2004 00:03:05 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 24 Apr 2004 00:03:05 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i3O034KG001525
	for <gdb-patches@sources.redhat.com>; Fri, 23 Apr 2004 20:03:04 -0400
Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i3O034p30953
	for <gdb-patches@sources.redhat.com>; Fri, 23 Apr 2004 20:03:04 -0400
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id B103C2BB1; Fri, 23 Apr 2004 14:41:49 -0400 (EDT)
Message-ID: <4089636D.2090605@gnu.org>
Date: Sat, 24 Apr 2004 00:03:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217
MIME-Version: 1.0
To: Orjan Friberg <orjan.friberg@axis.com>, Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Multiplexed registers and invalidating the register cache
References: <407D242B.109@axis.com> <20040414144607.GA5700@nevyn.them.org> <407E67EA.80701@axis.com> <407E70FD.7060709@axis.com> <407EAA4B.7000500@gnu.org> <407FD693.2080804@axis.com> <408030DB.3080708@gnu.org> <4083DE9C.7000208@axis.com> <40869FC4.2090407@gnu.org> <4087CF61.4030109@axis.com> <4087D794.10209@gnu.org> <4088FD0F.7050501@axis.com> <408927CF.10807@gnu.org> <40893437.2020907@axis.com>
In-Reply-To: <40893437.2020907@axis.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-04/txt/msg00588.txt.bz2

> +The target's register contents has changed.

FYI, this should probably read:
	The target's memory or register contents have [has?] changed.
eli?

> +@deftypefun void target_changed (struct target_ops *@var{current_target})

- As a parameter, I'd just use "target" (you've current_target as a 
parameter in several places) (one day there will be more than one target 
...).

> +#include "observer.h"

- you'll want to update Makefile.in

Otherwize assuming, eli's ok with the fixed wording, its ok to commit.

Andrew