From: Andrew Cagney <cagney@gnu.org>
To: drow@false.org
Cc: Jason Thorpe <thorpej@wasabisystems.com>,
Mark Kettenis <kettenis@chello.nl>,
gdb-patches@sources.redhat.com
Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder
Date: Wed, 03 Mar 2004 15:17:00 -0000 [thread overview]
Message-ID: <4045F702.5020506@gnu.org> (raw)
In-Reply-To: <4045246C.5000702@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
Draging the attached back into the thread :-)
> So something like:
>
> if (have symbol)
> {
> return (symbol matches __sigtramp.*);
> }
> else
> {
> return (mem[pc] == magic && mem[pc+1] == magic && ...);
> }
Making it:
if (have symbol)
-- new code
return symbol matches __sigtramp.*
else if (!find_pc_section)
-- old code, sigtramps do not exist in a section
return (mem[pc] == magic && mem[pc+1] == magic && ...)
yes, that's much better.
> Is it possible to add an extra guard to the else clause so that memory is only examined when there's a reasonable likelyhood of it being a sigtramp?
Andrew
[-- Attachment #2: Attached Message --]
[-- Type: message/rfc822, Size: 19 bytes --]
WARNING: multiple messages have this Message-ID
From: Andrew Cagney <cagney@gnu.org>
To: drow@false.org
Cc: Jason Thorpe <thorpej@wasabisystems.com>,
Mark Kettenis <kettenis@chello.nl>,
gdb-patches@sources.redhat.com
Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <4045F702.5020506@gnu.org> (raw)
Message-ID: <20040319000900.60tVx_iaduZZP5LV5gr6ALyflSV3V88QDpSDAW6pjfQ@z> (raw)
In-Reply-To: <4045246C.5000702@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
Draging the attached back into the thread :-)
> So something like:
>
> if (have symbol)
> {
> return (symbol matches __sigtramp.*);
> }
> else
> {
> return (mem[pc] == magic && mem[pc+1] == magic && ...);
> }
Making it:
if (have symbol)
-- new code
return symbol matches __sigtramp.*
else if (!find_pc_section)
-- old code, sigtramps do not exist in a section
return (mem[pc] == magic && mem[pc+1] == magic && ...)
yes, that's much better.
> Is it possible to add an extra guard to the else clause so that memory is only examined when there's a reasonable likelyhood of it being a sigtramp?
Andrew
[-- Attachment #2: Attached Message --]
[-- Type: message/rfc822, Size: 19 bytes --]
next prev parent reply other threads:[~2004-03-03 15:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Andrew Cagney
2004-03-01 1:05 ` Andrew Cagney
2004-03-01 1:26 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Andrew Cagney
2004-03-01 1:33 ` Andrew Cagney
2004-03-01 2:47 ` Daniel Jacobowitz
2004-03-01 9:34 ` Mark Kettenis
2004-03-19 0:09 ` Mark Kettenis
2004-03-19 0:09 ` Jason Thorpe
2004-03-02 23:29 ` Jason Thorpe
2004-03-03 20:43 ` Andrew Cagney
2004-03-03 20:46 ` Jason Thorpe
2004-03-03 21:20 ` Mark Kettenis
2004-03-19 0:09 ` Mark Kettenis
2004-03-19 0:09 ` Jason Thorpe
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-03 0:18 ` Andrew Cagney
2004-03-03 15:17 ` Andrew Cagney [this message]
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Kevin Buettner
2004-03-02 22:21 ` Kevin Buettner
2004-03-19 0:09 ` Andrew Cagney
2004-03-02 22:48 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4045F702.5020506@gnu.org \
--to=cagney@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
--cc=thorpej@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox