From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040302152128.1a9b033d@saguaro> (raw)
In-Reply-To: <40428C58.1020506@gnu.org>
On Sun, 29 Feb 2004 20:05:28 -0500
Andrew Cagney <cagney@gnu.org> wrote:
> * ppcnbsd-tdep.c: Include "trad-frame.h", and "frame-unwind.h".
> (struct ppcnbsd_sigtramp_cache, ppcnbsd_sigtramp_this_id)
> (ppcnbsd_sigtramp_prev_register, ppcnbsd_sigtramp_cache)
> (ppcnbsd_sigtramp_sniffer, ppcnbsd_sigtramp_unwind)
> (ppcnbsd_init_abi): Implement a NetBSD/PPC signal trampline
> unwinder, register.
After reading the disucssion, the only part about this which bothers
me is the part that you yourself had a question about:
> + if (frame_pc_unwind (next_frame) > 0x7f000000)
> + /* Assume anything that is vaguely on the stack is a signal
> + trampoline. */
> + return &ppcnbsd_sigtramp_unwind;
Given Mark K's comments, I think it would be better to check for a
specific instruction sequence. I know it's expensive, but it seems
like a more robust approach. (But, also given Mark K's comments,
it seems that a name based approach will work well in the future.)
Kevin
WARNING: multiple messages have this Message-ID
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder
Date: Tue, 02 Mar 2004 22:21:00 -0000 [thread overview]
Message-ID: <20040302152128.1a9b033d@saguaro> (raw)
Message-ID: <20040302222100.GEmBirxCFiNFMCaq252LiuPXvSwsGNXjmruNLBRTPuY@z> (raw)
In-Reply-To: <40428C58.1020506@gnu.org>
On Sun, 29 Feb 2004 20:05:28 -0500
Andrew Cagney <cagney@gnu.org> wrote:
> * ppcnbsd-tdep.c: Include "trad-frame.h", and "frame-unwind.h".
> (struct ppcnbsd_sigtramp_cache, ppcnbsd_sigtramp_this_id)
> (ppcnbsd_sigtramp_prev_register, ppcnbsd_sigtramp_cache)
> (ppcnbsd_sigtramp_sniffer, ppcnbsd_sigtramp_unwind)
> (ppcnbsd_init_abi): Implement a NetBSD/PPC signal trampline
> unwinder, register.
After reading the disucssion, the only part about this which bothers
me is the part that you yourself had a question about:
> + if (frame_pc_unwind (next_frame) > 0x7f000000)
> + /* Assume anything that is vaguely on the stack is a signal
> + trampoline. */
> + return &ppcnbsd_sigtramp_unwind;
Given Mark K's comments, I think it would be better to check for a
specific instruction sequence. I know it's expensive, but it seems
like a more robust approach. (But, also given Mark K's comments,
it seems that a name based approach will work well in the future.)
Kevin
next prev parent reply other threads:[~2004-03-02 22:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Andrew Cagney
2004-03-01 1:05 ` Andrew Cagney
2004-03-01 1:26 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Andrew Cagney
2004-03-01 1:33 ` Andrew Cagney
2004-03-01 2:47 ` Daniel Jacobowitz
2004-03-01 9:34 ` Mark Kettenis
2004-03-19 0:09 ` Mark Kettenis
2004-03-19 0:09 ` Jason Thorpe
2004-03-02 23:29 ` Jason Thorpe
2004-03-03 20:43 ` Andrew Cagney
2004-03-03 20:46 ` Jason Thorpe
2004-03-03 21:20 ` Mark Kettenis
2004-03-19 0:09 ` Mark Kettenis
2004-03-19 0:09 ` Jason Thorpe
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-03 0:18 ` Andrew Cagney
2004-03-03 15:17 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Kevin Buettner [this message]
2004-03-02 22:21 ` Kevin Buettner
2004-03-19 0:09 ` Andrew Cagney
2004-03-02 22:48 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040302152128.1a9b033d@saguaro \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox