From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22698 invoked by alias); 2 Mar 2004 22:21:35 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22691 invoked from network); 2 Mar 2004 22:21:34 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 2 Mar 2004 22:21:34 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i22MLYb31999 for ; Tue, 2 Mar 2004 17:21:34 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i22MLY819658 for ; Tue, 2 Mar 2004 17:21:34 -0500 Received: from localhost.localdomain (vpn50-15.rdu.redhat.com [172.16.50.15]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id i22MLXJ5030855 for ; Tue, 2 Mar 2004 17:21:34 -0500 Received: from saguaro (saguaro.lan [192.168.64.2]) by localhost.localdomain (8.12.10/8.12.10) with SMTP id i22MLScG015714 for ; Tue, 2 Mar 2004 15:21:28 -0700 Date: Tue, 02 Mar 2004 22:21:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder Message-ID: <20040302152128.1a9b033d@saguaro> In-Reply-To: <40428C58.1020506@gnu.org> References: <40428C58.1020506@gnu.org> Organization: Red Hat Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03.o/txt/msg00032.txt Message-ID: <20040302222100.GEmBirxCFiNFMCaq252LiuPXvSwsGNXjmruNLBRTPuY@z> On Sun, 29 Feb 2004 20:05:28 -0500 Andrew Cagney wrote: > * ppcnbsd-tdep.c: Include "trad-frame.h", and "frame-unwind.h". > (struct ppcnbsd_sigtramp_cache, ppcnbsd_sigtramp_this_id) > (ppcnbsd_sigtramp_prev_register, ppcnbsd_sigtramp_cache) > (ppcnbsd_sigtramp_sniffer, ppcnbsd_sigtramp_unwind) > (ppcnbsd_init_abi): Implement a NetBSD/PPC signal trampline > unwinder, register. After reading the disucssion, the only part about this which bothers me is the part that you yourself had a question about: > + if (frame_pc_unwind (next_frame) > 0x7f000000) > + /* Assume anything that is vaguely on the stack is a signal > + trampoline. */ > + return &ppcnbsd_sigtramp_unwind; Given Mark K's comments, I think it would be better to check for a specific instruction sequence. I know it's expensive, but it seems like a more robust approach. (But, also given Mark K's comments, it seems that a name based approach will work well in the future.) Kevin