From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 590 invoked by alias); 3 Mar 2004 15:17:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 582 invoked from network); 3 Mar 2004 15:17:27 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 3 Mar 2004 15:17:27 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D44062B92; Wed, 3 Mar 2004 10:17:22 -0500 (EST) Message-ID: <4045F702.5020506@gnu.org> Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: drow@false.org Cc: Jason Thorpe , Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [rfa:NetBSD/ppc] Implement signal trampoline unwinder References: <40428C58.1020506@gnu.org> <20040301012656.GA16265@nevyn.them.org> <404292D7.9040100@gnu.org> <20040301024711.GA27915@nevyn.them.org> <200403010933.i219X4v3002550@elgar.kettenis.dyndns.org> <6FDEB6FE-6CA1-11D8-BE41-000A957650EC@wasabisystems.com> <4045246C.5000702@gnu.org> In-Reply-To: <4045246C.5000702@gnu.org> Content-Type: multipart/mixed; boundary="------------010609000302070405080102" X-SW-Source: 2004-03/txt/msg00040.txt.bz2 Message-ID: <20040319000900.60tVx_iaduZZP5LV5gr6ALyflSV3V88QDpSDAW6pjfQ@z> This is a multi-part message in MIME format. --------------010609000302070405080102 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 664 Draging the attached back into the thread :-) > So something like: > > if (have symbol) > { > return (symbol matches __sigtramp.*); > } > else > { > return (mem[pc] == magic && mem[pc+1] == magic && ...); > } Making it: if (have symbol) -- new code return symbol matches __sigtramp.* else if (!find_pc_section) -- old code, sigtramps do not exist in a section return (mem[pc] == magic && mem[pc+1] == magic && ...) yes, that's much better. > Is it possible to add an extra guard to the else clause so that memory is only examined when there's a reasonable likelyhood of it being a sigtramp? Andrew --------------010609000302070405080102 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Attached Message" Content-length: 1 Content-length: 0 --------------010609000302070405080102--