* [RFA]: pending breakpoint cosmetic change
@ 2004-02-20 1:15 Jeff Johnston
2004-02-23 15:57 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnston @ 2004-02-20 1:15 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
I noticed recently that my attempt to put in spaces after the <PENDING> address
in an info breakpoint is not needed. It actually adds extra spaces because gdb
gets the field alignment right.
Ok to commit?
-- Jeff J.
2004-02-19 Jeff Johnston <jjohnstn@redhat.com>
* breakpoint.c (print_one_breakpoint): Do not output spaces
after printing <PENDING> for a pending breakpoint.
[-- Attachment #2: nospaces.patch --]
[-- Type: text/plain, Size: 712 bytes --]
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.158
diff -u -p -r1.158 breakpoint.c
--- breakpoint.c 3 Feb 2004 22:47:40 -0000 1.158
+++ breakpoint.c 20 Feb 2004 01:12:34 -0000
@@ -3471,13 +3471,7 @@ print_one_breakpoint (struct breakpoint
{
annotate_field (4);
if (b->pending)
- {
- ui_out_field_string (uiout, "addr", "<PENDING>");
- if (TARGET_ADDR_BIT <= 32)
- ui_out_spaces (uiout, 2);
- else
- ui_out_spaces (uiout, 8);
- }
+ ui_out_field_string (uiout, "addr", "<PENDING>");
else
ui_out_field_core_addr (uiout, "addr", b->loc->address);
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA]: pending breakpoint cosmetic change
2004-02-20 1:15 [RFA]: pending breakpoint cosmetic change Jeff Johnston
@ 2004-02-23 15:57 ` Andrew Cagney
2004-02-23 20:30 ` Jeff Johnston
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2004-02-23 15:57 UTC (permalink / raw)
To: Jeff Johnston; +Cc: gdb-patches
> - {
> - ui_out_field_string (uiout, "addr", "<PENDING>");
> - if (TARGET_ADDR_BIT <= 32)
> - ui_out_spaces (uiout, 2);
> - else
> - ui_out_spaces (uiout, 8);
> - }
> + ui_out_field_string (uiout, "addr", "<PENDING>");
Yep!
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA]: pending breakpoint cosmetic change
2004-02-23 15:57 ` Andrew Cagney
@ 2004-02-23 20:30 ` Jeff Johnston
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnston @ 2004-02-23 20:30 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
Thanks. Patch checked in.
-- Jeff J.
Andrew Cagney wrote:
>> - {
>> - ui_out_field_string (uiout, "addr", "<PENDING>");
>> - if (TARGET_ADDR_BIT <= 32)
>> - ui_out_spaces (uiout, 2);
>> - else
>> - ui_out_spaces (uiout, 8);
>> - }
>> + ui_out_field_string (uiout, "addr", "<PENDING>");
>
>
> Yep!
>
> Andrew
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-23 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-20 1:15 [RFA]: pending breakpoint cosmetic change Jeff Johnston
2004-02-23 15:57 ` Andrew Cagney
2004-02-23 20:30 ` Jeff Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox