From: Jeff Johnston <jjohnstn@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA]: pending breakpoint cosmetic change
Date: Fri, 20 Feb 2004 01:15:00 -0000 [thread overview]
Message-ID: <40355FC6.6010606@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 402 bytes --]
I noticed recently that my attempt to put in spaces after the <PENDING> address
in an info breakpoint is not needed. It actually adds extra spaces because gdb
gets the field alignment right.
Ok to commit?
-- Jeff J.
2004-02-19 Jeff Johnston <jjohnstn@redhat.com>
* breakpoint.c (print_one_breakpoint): Do not output spaces
after printing <PENDING> for a pending breakpoint.
[-- Attachment #2: nospaces.patch --]
[-- Type: text/plain, Size: 712 bytes --]
Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.158
diff -u -p -r1.158 breakpoint.c
--- breakpoint.c 3 Feb 2004 22:47:40 -0000 1.158
+++ breakpoint.c 20 Feb 2004 01:12:34 -0000
@@ -3471,13 +3471,7 @@ print_one_breakpoint (struct breakpoint
{
annotate_field (4);
if (b->pending)
- {
- ui_out_field_string (uiout, "addr", "<PENDING>");
- if (TARGET_ADDR_BIT <= 32)
- ui_out_spaces (uiout, 2);
- else
- ui_out_spaces (uiout, 8);
- }
+ ui_out_field_string (uiout, "addr", "<PENDING>");
else
ui_out_field_core_addr (uiout, "addr", b->loc->address);
}
next reply other threads:[~2004-02-20 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-20 1:15 Jeff Johnston [this message]
2004-02-23 15:57 ` Andrew Cagney
2004-02-23 20:30 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40355FC6.6010606@redhat.com \
--to=jjohnstn@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox