From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21850 invoked by alias); 20 Feb 2004 01:15:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21843 invoked from network); 20 Feb 2004 01:15:50 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 20 Feb 2004 01:15:50 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 396EC80001E for ; Thu, 19 Feb 2004 20:15:50 -0500 (EST) Message-ID: <40355FC6.6010606@redhat.com> Date: Fri, 20 Feb 2004 01:15:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [RFA]: pending breakpoint cosmetic change Content-Type: multipart/mixed; boundary="------------020401000408050901070505" X-SW-Source: 2004-02/txt/msg00550.txt.bz2 This is a multi-part message in MIME format. --------------020401000408050901070505 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 402 I noticed recently that my attempt to put in spaces after the address in an info breakpoint is not needed. It actually adds extra spaces because gdb gets the field alignment right. Ok to commit? -- Jeff J. 2004-02-19 Jeff Johnston * breakpoint.c (print_one_breakpoint): Do not output spaces after printing for a pending breakpoint. --------------020401000408050901070505 Content-Type: text/plain; name="nospaces.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="nospaces.patch" Content-length: 712 Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.158 diff -u -p -r1.158 breakpoint.c --- breakpoint.c 3 Feb 2004 22:47:40 -0000 1.158 +++ breakpoint.c 20 Feb 2004 01:12:34 -0000 @@ -3471,13 +3471,7 @@ print_one_breakpoint (struct breakpoint { annotate_field (4); if (b->pending) - { - ui_out_field_string (uiout, "addr", ""); - if (TARGET_ADDR_BIT <= 32) - ui_out_spaces (uiout, 2); - else - ui_out_spaces (uiout, 8); - } + ui_out_field_string (uiout, "addr", ""); else ui_out_field_core_addr (uiout, "addr", b->loc->address); } --------------020401000408050901070505--