Re: [RFA 2nd] hpread.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr,..

[Pierre Muller <muller@cerbere.u-strasbg.fr>]

At 15:32 26/04/2002 , Andrew Cagney a écrit:
>>in hpread.c
>>there is a line with
>>#include "syms.h"
>>but there is no syms.h in the gdb sources...
>>If I do a 'grep -n syms.h *.c in gdb directory,
>>I get only this:
>>$ grep -n syms.h *.c
>>hpread.c:29:#include "syms.h"
>>somread.c:25:#include <syms.h>
>>Is the hpread.c file obsolete?
>>Or shouldn't it be also
>>#include <syms.h>
>>like in somread.c?
>
>I need to tread carefuly here, skating on thin ice :-)  There is the strict ISO C defined behavour of "" vs <> and then there are accepted conventions (note plural).
>
>Within GDB, the accepted convention is to use <> as as "syms.h" is a system header.
>
>In theory, it should be possible for you to compile hpread.c on any system, because of includes like the above, it isn't (hence the MAINTAINERS file marks it as broken).  Consequently, yes, ok.
>
>Andrew

I hope I did understand you correctly.
I can commit this patch without testing that it complies correctly
because it is known to belong to a broken target.

Thus, I committed it.



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99