From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29545 invoked by alias); 29 Apr 2002 11:09:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29485 invoked from network); 29 Apr 2002 11:09:27 -0000 Received: from unknown (HELO cerbere.u-strasbg.fr) (130.79.112.7) by sources.redhat.com with SMTP; 29 Apr 2002 11:09:27 -0000 Received: from laocoon (laocoon.u-strasbg.fr [130.79.112.72]) by cerbere.u-strasbg.fr (8.9.3/8.8.7) with ESMTP id NAA04327; Mon, 29 Apr 2002 13:09:22 +0200 Message-Id: <4.2.0.58.20020429130031.013421a0@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Mon, 29 Apr 2002 04:09:00 -0000 To: Andrew Cagney From: Pierre Muller Subject: Re: [RFA 2nd] hpread.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr,.. Cc: gdb-patches@sources.redhat.com In-Reply-To: <3CC956F6.5000100@cygnus.com> References: <4.2.0.58.20020426105725.0233c338@ics.u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit X-SW-Source: 2002-04/txt/msg01116.txt.bz2 At 15:32 26/04/2002 , Andrew Cagney a écrit: >>in hpread.c >>there is a line with >>#include "syms.h" >>but there is no syms.h in the gdb sources... >>If I do a 'grep -n syms.h *.c in gdb directory, >>I get only this: >>$ grep -n syms.h *.c >>hpread.c:29:#include "syms.h" >>somread.c:25:#include >>Is the hpread.c file obsolete? >>Or shouldn't it be also >>#include >>like in somread.c? > >I need to tread carefuly here, skating on thin ice :-) There is the strict ISO C defined behavour of "" vs <> and then there are accepted conventions (note plural). > >Within GDB, the accepted convention is to use <> as as "syms.h" is a system header. > >In theory, it should be possible for you to compile hpread.c on any system, because of includes like the above, it isn't (hence the MAINTAINERS file marks it as broken). Consequently, yes, ok. > >Andrew I hope I did understand you correctly. I can commit this patch without testing that it complies correctly because it is known to belong to a broken target. Thus, I committed it. Pierre Muller Institut Charles Sadron 6,rue Boussingault F 67083 STRASBOURG CEDEX (France) mailto:muller@ics.u-strasbg.fr Phone : (33)-3-88-41-40-07 Fax : (33)-3-88-41-40-99