Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c

[Daniel Jacobowitz <drow@mvista.com>]

On Wed, Apr 24, 2002 at 11:50:40AM -0700, Michael Snyder wrote:
> Daniel Jacobowitz wrote:
> > 
> > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote:
> > > This is a second of the files that I listed in
> > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
> > > as still having direct uses of stderr.
> > >
> > > I did not fix a 80 char overflow, because I didn't find a good way to do it:
> > > If I try to align the string "Psymtab for %s already read in.  Shouldn't happen.\n"
> > > with gdb_stderr, I still get an overflow, how show I indent the args then?
> > > Should I break the string constant?
> > 
> > Yes, I'd recommend:
> > 
> > -      fprintf (stderr, "Psymtab for %s already read in.  Shouldn't happen.\n",
> > +      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  "
> >                                        "Shouldn't happen.\n",
> 
> 
> I thought there was some kind of caveat against the use of
> string concatenation ?

Perhaps you're thinking of token concatenation, or stringification?  Or
multiline strings?  I believe "a" "b" has worked even in K&R compilers.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer