From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14615 invoked by alias); 24 Apr 2002 19:29:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14606 invoked from network); 24 Apr 2002 19:29:24 -0000 Received: from unknown (HELO nevyn.them.org) (128.2.145.6) by sources.redhat.com with SMTP; 24 Apr 2002 19:29:24 -0000 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 170SSH-0005MT-00; Wed, 24 Apr 2002 15:29:29 -0400 Date: Wed, 24 Apr 2002 12:29:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c Message-ID: <20020424152929.A20589@nevyn.them.org> Mail-Followup-To: Michael Snyder , gdb-patches@sources.redhat.com References: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> <20020424102516.C6310@nevyn.them.org> <3CC6FE80.D2EC8A7E@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CC6FE80.D2EC8A7E@redhat.com> User-Agent: Mutt/1.3.23i X-SW-Source: 2002-04/txt/msg00969.txt.bz2 On Wed, Apr 24, 2002 at 11:50:40AM -0700, Michael Snyder wrote: > Daniel Jacobowitz wrote: > > > > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote: > > > This is a second of the files that I listed in > > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html > > > as still having direct uses of stderr. > > > > > > I did not fix a 80 char overflow, because I didn't find a good way to do it: > > > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" > > > with gdb_stderr, I still get an overflow, how show I indent the args then? > > > Should I break the string constant? > > > > Yes, I'd recommend: > > > > - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", > > + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. " > > "Shouldn't happen.\n", > > > I thought there was some kind of caveat against the use of > string concatenation ? Perhaps you're thinking of token concatenation, or stringification? Or multiline strings? I believe "a" "b" has worked even in K&R compilers. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer