Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in  hpread.c
Date: Wed, 24 Apr 2002 12:02:00 -0000	[thread overview]
Message-ID: <3CC6FE80.D2EC8A7E@redhat.com> (raw)
In-Reply-To: <20020424102516.C6310@nevyn.them.org>

Daniel Jacobowitz wrote:
> 
> On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote:
> > This is a second of the files that I listed in
> > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html
> > as still having direct uses of stderr.
> >
> > I did not fix a 80 char overflow, because I didn't find a good way to do it:
> > If I try to align the string "Psymtab for %s already read in.  Shouldn't happen.\n"
> > with gdb_stderr, I still get an overflow, how show I indent the args then?
> > Should I break the string constant?
> 
> Yes, I'd recommend:
> 
> -      fprintf (stderr, "Psymtab for %s already read in.  Shouldn't happen.\n",
> +      fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in.  "
>                                        "Shouldn't happen.\n",


I thought there was some kind of caveat against the use of
string concatenation ?


  reply	other threads:[~2002-04-24 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-24  6:18 Pierre Muller
2002-04-24  7:25 ` Daniel Jacobowitz
2002-04-24 12:02   ` Michael Snyder [this message]
2002-04-24 12:29     ` Daniel Jacobowitz
2002-04-25  8:38       ` Andrew Cagney
2002-04-25  9:35         ` Pierre Muller
2002-04-25 10:16           ` Andrew Cagney
2002-04-25 11:52             ` Daniel Jacobowitz
2002-04-24 12:08 ` [RFA/RFC] printf (stderr,... ->fprintf_unfiltered(gdb_stderr,... " Michael Snyder
2002-04-24 12:40   ` Daniel Jacobowitz
2002-04-26  2:10 ` [RFA 2nd] hpread.c printf (stderr,... ->fprintf_unfiltered (gdb_stderr, Pierre Muller
2002-04-26  6:32   ` Andrew Cagney
2002-04-29  4:09     ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC6FE80.D2EC8A7E@redhat.com \
    --to=msnyder@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox