From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30846 invoked by alias); 24 Apr 2002 19:02:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30839 invoked from network); 24 Apr 2002 19:02:46 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 24 Apr 2002 19:02:46 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id MAA22039; Wed, 24 Apr 2002 12:02:43 -0700 (PDT) Message-ID: <3CC6FE80.D2EC8A7E@redhat.com> Date: Wed, 24 Apr 2002 12:02:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] printf (stderr,... ->fprintf_unfiltered (gdb_stderr,... in hpread.c References: <4.2.0.58.20020424151049.01eb0900@ics.u-strasbg.fr> <20020424102516.C6310@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00964.txt.bz2 Daniel Jacobowitz wrote: > > On Wed, Apr 24, 2002 at 03:16:16PM +0200, Pierre Muller wrote: > > This is a second of the files that I listed in > > http://sources.redhat.com/ml/gdb/2002-02/msg00212.html > > as still having direct uses of stderr. > > > > I did not fix a 80 char overflow, because I didn't find a good way to do it: > > If I try to align the string "Psymtab for %s already read in. Shouldn't happen.\n" > > with gdb_stderr, I still get an overflow, how show I indent the args then? > > Should I break the string constant? > > Yes, I'd recommend: > > - fprintf (stderr, "Psymtab for %s already read in. Shouldn't happen.\n", > + fprintf_unfiltered (gdb_stderr, "Psymtab for %s already read in. " > "Shouldn't happen.\n", I thought there was some kind of caveat against the use of string concatenation ?