Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Correct machine name in config/m68k/tm-nbsd.h
@ 2002-04-24  5:39 Pierre Muller
  2002-04-24  7:22 ` Daniel Jacobowitz
  2002-05-02  6:47 ` Pierre Muller
  0 siblings, 2 replies; 4+ messages in thread
From: Pierre Muller @ 2002-04-24  5:39 UTC (permalink / raw)
  To: gdb-patches


This seems to be a pretty obviopus fix, 
that I came across by doing
a 'grep -n -i I386 */*/*'
in gdb source dir.

  I still have a question:
should I update the copyright line for such an obvious fix?
(I would vote no....)

ChangeLog entry:

2002-04-24  Pierre Muller  <ics.u-strasbg.fr>
	* config/m68k/tm-nbsd.h: Correct machine name.
  

Index: config/m68k/tm-nbsd.h
===================================================================
RCS file: /cvs/src/src/gdb/config/m68k/tm-nbsd.h,v
retrieving revision 1.3
diff -u -p -r1.3 tm-nbsd.h
--- config/m68k/tm-nbsd.h       6 Mar 2001 08:21:30 -0000       1.3
+++ config/m68k/tm-nbsd.h       24 Apr 2002 12:34:27 -0000
@@ -1,4 +1,4 @@
-/* Macro definitions for i386 running under NetBSD.
+/* Macro definitions for m68k running under NetBSD.
     Copyright 1994, 1996, 2001 Free Software Foundation, Inc.

     This file is part of GDB.



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] Correct machine name in config/m68k/tm-nbsd.h
  2002-04-24  5:39 [RFA] Correct machine name in config/m68k/tm-nbsd.h Pierre Muller
@ 2002-04-24  7:22 ` Daniel Jacobowitz
  2002-04-24 21:52   ` Eli Zaretskii
  2002-05-02  6:47 ` Pierre Muller
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Jacobowitz @ 2002-04-24  7:22 UTC (permalink / raw)
  To: gdb-patches

On Wed, Apr 24, 2002 at 02:37:33PM +0200, Pierre Muller wrote:
> 
> This seems to be a pretty obviopus fix, 
> that I came across by doing
> a 'grep -n -i I386 */*/*'
> in gdb source dir.
> 
>   I still have a question:
> should I update the copyright line for such an obvious fix?
> (I would vote no....)

I'm pretty sure that the correct answer is yes.  You're modifying the
file, regardless of obviousness.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] Correct machine name in config/m68k/tm-nbsd.h
  2002-04-24  7:22 ` Daniel Jacobowitz
@ 2002-04-24 21:52   ` Eli Zaretskii
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2002-04-24 21:52 UTC (permalink / raw)
  To: Daniel Jacobowitz; +Cc: gdb-patches


On Wed, 24 Apr 2002, Daniel Jacobowitz wrote:

> >   I still have a question:
> > should I update the copyright line for such an obvious fix?
> > (I would vote no....)
> 
> I'm pretty sure that the correct answer is yes.  You're modifying the
> file, regardless of obviousness.

FYI, the guidelines for such decisions are in standards.texi (IIRC).


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] Correct machine name in config/m68k/tm-nbsd.h
  2002-04-24  5:39 [RFA] Correct machine name in config/m68k/tm-nbsd.h Pierre Muller
  2002-04-24  7:22 ` Daniel Jacobowitz
@ 2002-05-02  6:47 ` Pierre Muller
  1 sibling, 0 replies; 4+ messages in thread
From: Pierre Muller @ 2002-05-02  6:47 UTC (permalink / raw)
  To: gdb-patches

At 14:37 24/04/2002 , Pierre Muller a écrit:

>This seems to be a pretty obviopus fix, 
>that I came across by doing
>a 'grep -n -i I386 */*/*'
>in gdb source dir.
>
>   I still have a question:
>should I update the copyright line for such an obvious fix?
>(I would vote no....)
>
>ChangeLog entry:
>
>2002-04-24  Pierre Muller  <ics.u-strasbg.fr>
>         * config/m68k/tm-nbsd.h: Correct machine name.

After the discussion that followed, I choose
to commit this as an obvious fix, that does not 
need a copyright update.



Pierre Muller
Institut Charles Sadron
6,rue Boussingault
F 67083 STRASBOURG CEDEX (France)
mailto:muller@ics.u-strasbg.fr
Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-05-02 13:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-24  5:39 [RFA] Correct machine name in config/m68k/tm-nbsd.h Pierre Muller
2002-04-24  7:22 ` Daniel Jacobowitz
2002-04-24 21:52   ` Eli Zaretskii
2002-05-02  6:47 ` Pierre Muller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox