Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Joel Brobecker <brobecker@gnat.com>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFC] Unexpected automatic language switch - get_frame_language()
Date: Wed, 10 Dec 2003 16:14:00 -0000	[thread overview]
Message-ID: <3FD74659.9020900@gnu.org> (raw)
In-Reply-To: <20031210015055.GB842@gnat.com>

> Looked at frame_addr_in_block?
> 
> 
> That's (almost) the function I was trying to remember about. Thanks a
> lot!  The following patch addresses the problem in a way that I hope
> will satisfy MichaelS' concerns.
> 
> 2003-12-09  J. Brobecker  <brobecker@gnat.com>
> 
>         * frame.c (select_frame): Get the current frame PC using
>         get_frame_address_in_block() instead of get_frame_pc().
>         * stack.c (get_frame_language): Likewise.
> 
> Tested on x86-linux, with no regression.
> 
> OK to apply?

Yes, but just add a comment at each point reminding us why the PC is 
wrong before committing.

Andrew



  reply	other threads:[~2003-12-10 16:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-05 22:48 Joel Brobecker
2003-12-05 23:57 ` Michael Snyder
2003-12-06  0:18   ` Joel Brobecker
2003-12-06  0:28     ` Andrew Cagney
2003-12-10  1:50       ` Joel Brobecker
2003-12-10 16:14         ` Andrew Cagney [this message]
2003-12-10 17:42           ` Joel Brobecker
2003-12-06  0:42     ` Michael Snyder
2003-12-10 17:47 ` Daniel Jacobowitz
2003-12-10 18:10   ` Joel Brobecker
2003-12-10 18:20     ` Daniel Jacobowitz
2003-12-10 19:16       ` Joel Brobecker
2003-12-10 19:18         ` Daniel Jacobowitz
2003-12-10 18:33     ` Ada's throw/catch; Was: " Andrew Cagney
2003-12-10 19:04       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FD74659.9020900@gnu.org \
    --to=cagney@gnu.org \
    --cc=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox