From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10477 invoked by alias); 10 Dec 2003 16:14:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10460 invoked from network); 10 Dec 2003 16:14:20 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.20) by sources.redhat.com with SMTP; 10 Dec 2003 16:14:20 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 967DF2B8F; Wed, 10 Dec 2003 11:14:17 -0500 (EST) Message-ID: <3FD74659.9020900@gnu.org> Date: Wed, 10 Dec 2003 16:14:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030820 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [RFC] Unexpected automatic language switch - get_frame_language() References: <20031205224807.GE716@gnat.com> <3FD11B60.2040008@redhat.com> <20031206001815.GF716@gnat.com> <3FD12296.8090809@gnu.org> <20031210015055.GB842@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-12/txt/msg00289.txt.bz2 > Looked at frame_addr_in_block? > > > That's (almost) the function I was trying to remember about. Thanks a > lot! The following patch addresses the problem in a way that I hope > will satisfy MichaelS' concerns. > > 2003-12-09 J. Brobecker > > * frame.c (select_frame): Get the current frame PC using > get_frame_address_in_block() instead of get_frame_pc(). > * stack.c (get_frame_language): Likewise. > > Tested on x86-linux, with no regression. > > OK to apply? Yes, but just add a comment at each point reminding us why the PC is wrong before committing. Andrew