* [PATCH] update cgen read_memory_func
@ 2003-06-18 5:33 Doug Evans
2003-06-18 15:03 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Doug Evans @ 2003-06-18 5:33 UTC (permalink / raw)
To: gdb-patches
fyi, I'll be checking this in.
2003-06-17 Doug Evans <dje@sebabeach.org>
* cgen-trace.h (sim_disasm_read_memory): Update args to be compatible
with disassemble_info:read_memory_func.
* cgen-trace.c (sim_disasm_read_memory): Ditto.
Index: cgen-trace.c
===================================================================
RCS file: /cvs/src/src/sim/common/cgen-trace.c,v
retrieving revision 1.5
diff -u -p -r1.5 cgen-trace.c
--- cgen-trace.c 23 Dec 2000 21:52:14 -0000 1.5
+++ cgen-trace.c 18 Jun 2003 05:03:40 -0000
@@ -322,12 +322,12 @@ sim_disasm_sprintf VPARAMS ((SFILE *f, c
/* Memory read support for an opcodes disassembler. */
int
-sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length,
+sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, unsigned int length,
struct disassemble_info *info)
{
SIM_CPU *cpu = (SIM_CPU *) info->application_data;
SIM_DESC sd = CPU_STATE (cpu);
- int length_read;
+ unsigned length_read;
length_read = sim_core_read_buffer (sd, cpu, read_map, myaddr, memaddr,
length);
Index: cgen-trace.h
===================================================================
RCS file: /cvs/src/src/sim/common/cgen-trace.h,v
retrieving revision 1.2
diff -u -p -r1.2 cgen-trace.h
--- cgen-trace.h 14 Oct 2002 10:55:39 -0000 1.2
+++ cgen-trace.h 18 Jun 2003 05:03:40 -0000
@@ -81,7 +81,7 @@ extern int sim_disasm_sprintf (SFILE *,
#ifdef __BFD_H_SEEN__
struct disassemble_info;
extern int
-sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, int length_,
+sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, unsigned int length_,
struct disassemble_info *info_);
extern void
sim_disasm_perror_memory (int status_, bfd_vma memaddr_,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] update cgen read_memory_func
2003-06-18 5:33 [PATCH] update cgen read_memory_func Doug Evans
@ 2003-06-18 15:03 ` Andrew Cagney
2003-06-18 16:08 ` Doug Evans
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2003-06-18 15:03 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
> fyi, I'll be checking this in.
>
> 2003-06-17 Doug Evans <dje@sebabeach.org>
>
> * cgen-trace.h (sim_disasm_read_memory): Update args to be compatible
> with disassemble_info:read_memory_func.
> * cgen-trace.c (sim_disasm_read_memory): Ditto.
Doug.
Only people with an FSF GDB copyright assignment are permitted to make
changes to the FSF's GDB sources.
Andrew
> Index: cgen-trace.c
> ===================================================================
> RCS file: /cvs/src/src/sim/common/cgen-trace.c,v
> retrieving revision 1.5
> diff -u -p -r1.5 cgen-trace.c
> --- cgen-trace.c 23 Dec 2000 21:52:14 -0000 1.5
> +++ cgen-trace.c 18 Jun 2003 05:03:40 -0000
> @@ -322,12 +322,12 @@ sim_disasm_sprintf VPARAMS ((SFILE *f, c
> /* Memory read support for an opcodes disassembler. */
>
> int
> -sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length,
> +sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, unsigned int length,
> struct disassemble_info *info)
> {
> SIM_CPU *cpu = (SIM_CPU *) info->application_data;
> SIM_DESC sd = CPU_STATE (cpu);
> - int length_read;
> + unsigned length_read;
>
> length_read = sim_core_read_buffer (sd, cpu, read_map, myaddr, memaddr,
> length);
> Index: cgen-trace.h
> ===================================================================
> RCS file: /cvs/src/src/sim/common/cgen-trace.h,v
> retrieving revision 1.2
> diff -u -p -r1.2 cgen-trace.h
> --- cgen-trace.h 14 Oct 2002 10:55:39 -0000 1.2
> +++ cgen-trace.h 18 Jun 2003 05:03:40 -0000
> @@ -81,7 +81,7 @@ extern int sim_disasm_sprintf (SFILE *,
> #ifdef __BFD_H_SEEN__
> struct disassemble_info;
> extern int
> -sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, int length_,
> +sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, unsigned int length_,
> struct disassemble_info *info_);
> extern void
> sim_disasm_perror_memory (int status_, bfd_vma memaddr_,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] update cgen read_memory_func
2003-06-18 15:03 ` Andrew Cagney
@ 2003-06-18 16:08 ` Doug Evans
2003-06-18 16:29 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Doug Evans @ 2003-06-18 16:08 UTC (permalink / raw)
To: ac131313; +Cc: gdb-patches
Date: Wed, 18 Jun 2003 11:02:58 -0400
From: Andrew Cagney <ac131313@redhat.com>
> fyi, I'll be checking this in.
>
> 2003-06-17 Doug Evans <dje@sebabeach.org>
>
> * cgen-trace.h (sim_disasm_read_memory): Update args to be compatible
> with disassemble_info:read_memory_func.
> * cgen-trace.c (sim_disasm_read_memory): Ditto.
Doug.
Only people with an FSF GDB copyright assignment are permitted to make
changes to the FSF's GDB sources.
I'm not sure what you're saying.
Are you saying someone else needs to check this in?
Or are you saying that this patch can't go in at all?
This patch doesn't need a copyright assignment. It's far too small.
[Otherwise I wouldn't have gone to this trouble...]
> Index: cgen-trace.c
> ===================================================================
> RCS file: /cvs/src/src/sim/common/cgen-trace.c,v
> retrieving revision 1.5
> diff -u -p -r1.5 cgen-trace.c
> --- cgen-trace.c 23 Dec 2000 21:52:14 -0000 1.5
> +++ cgen-trace.c 18 Jun 2003 05:03:40 -0000
> @@ -322,12 +322,12 @@ sim_disasm_sprintf VPARAMS ((SFILE *f, c
> /* Memory read support for an opcodes disassembler. */
>
> int
> -sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length,
> +sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, unsigned int length,
> struct disassemble_info *info)
> {
> SIM_CPU *cpu = (SIM_CPU *) info->application_data;
> SIM_DESC sd = CPU_STATE (cpu);
> - int length_read;
> + unsigned length_read;
>
> length_read = sim_core_read_buffer (sd, cpu, read_map, myaddr, memaddr,
> length);
> Index: cgen-trace.h
> ===================================================================
> RCS file: /cvs/src/src/sim/common/cgen-trace.h,v
> retrieving revision 1.2
> diff -u -p -r1.2 cgen-trace.h
> --- cgen-trace.h 14 Oct 2002 10:55:39 -0000 1.2
> +++ cgen-trace.h 18 Jun 2003 05:03:40 -0000
> @@ -81,7 +81,7 @@ extern int sim_disasm_sprintf (SFILE *,
> #ifdef __BFD_H_SEEN__
> struct disassemble_info;
> extern int
> -sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, int length_,
> +sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, unsigned int length_,
> struct disassemble_info *info_);
> extern void
> sim_disasm_perror_memory (int status_, bfd_vma memaddr_,
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] update cgen read_memory_func
2003-06-18 16:08 ` Doug Evans
@ 2003-06-18 16:29 ` Andrew Cagney
2003-06-18 16:51 ` Doug Evans
2003-06-20 17:38 ` Frank Ch. Eigler
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Cagney @ 2003-06-18 16:29 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
> I'm not sure what you're saying.
> Are you saying someone else needs to check this in?
> Or are you saying that this patch can't go in at all?
>
> This patch doesn't need a copyright assignment. It's far too small.
> [Otherwise I wouldn't have gone to this trouble...]
From gdb/MAINTAINERS:
> Write After Approval
> (alphabetic)
>
> To get recommended for the Write After Approval list you need a valid
> FSF assignment and have submitted one good patch.
Please do not assume that your ability to make changes in the SRC
repository gives you permission to make changes to it.
Send the patch to gdb-patches and I'm sure someone will check it in.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] update cgen read_memory_func
2003-06-18 16:29 ` Andrew Cagney
@ 2003-06-18 16:51 ` Doug Evans
2003-06-20 17:38 ` Frank Ch. Eigler
1 sibling, 0 replies; 6+ messages in thread
From: Doug Evans @ 2003-06-18 16:51 UTC (permalink / raw)
To: ac131313; +Cc: gdb-patches
Andrew writes:
Please do not assume that your ability to make changes in the SRC
repository gives you permission to make changes to it.
Gee, Andrew, I thought you had more respect for my judgement than that.
I see that was in error. Well, at least that's settled. Progress.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] update cgen read_memory_func
2003-06-18 16:29 ` Andrew Cagney
2003-06-18 16:51 ` Doug Evans
@ 2003-06-20 17:38 ` Frank Ch. Eigler
1 sibling, 0 replies; 6+ messages in thread
From: Frank Ch. Eigler @ 2003-06-20 17:38 UTC (permalink / raw)
To: Andrew Cagney; +Cc: Doug Evans, gdb-patches
cagney wrote:
> [...]
> Send the patch to gdb-patches and I'm sure someone will check it in.
I don't know about the need for all this rigid formality,
but for what it's worth, I've committed this for Doug.
- FChE
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-06-20 17:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-06-18 5:33 [PATCH] update cgen read_memory_func Doug Evans
2003-06-18 15:03 ` Andrew Cagney
2003-06-18 16:08 ` Doug Evans
2003-06-18 16:29 ` Andrew Cagney
2003-06-18 16:51 ` Doug Evans
2003-06-20 17:38 ` Frank Ch. Eigler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox