From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5506 invoked by alias); 18 Jun 2003 16:08:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14306 invoked from network); 18 Jun 2003 15:56:20 -0000 Received: from unknown (HELO mail.sebabeach.org) (64.165.110.50) by sources.redhat.com with SMTP; 18 Jun 2003 15:56:20 -0000 Received: by mail.sebabeach.org (Postfix, from userid 42) id 46273B536; Wed, 18 Jun 2003 08:59:26 -0700 (PDT) From: Doug Evans To: ac131313@redhat.com Cc: gdb-patches@sources.redhat.com In-reply-to: <3EF07F22.7040902@redhat.com> (message from Andrew Cagney on Wed, 18 Jun 2003 11:02:58 -0400) Subject: Re: [PATCH] update cgen read_memory_func References: <20030618052001.1214AB536@mail.sebabeach.org> <3EF07F22.7040902@redhat.com> Message-Id: <20030618155926.46273B536@mail.sebabeach.org> Date: Wed, 18 Jun 2003 16:08:00 -0000 X-SW-Source: 2003-06/txt/msg00595.txt.bz2 Date: Wed, 18 Jun 2003 11:02:58 -0400 From: Andrew Cagney > fyi, I'll be checking this in. > > 2003-06-17 Doug Evans > > * cgen-trace.h (sim_disasm_read_memory): Update args to be compatible > with disassemble_info:read_memory_func. > * cgen-trace.c (sim_disasm_read_memory): Ditto. Doug. Only people with an FSF GDB copyright assignment are permitted to make changes to the FSF's GDB sources. I'm not sure what you're saying. Are you saying someone else needs to check this in? Or are you saying that this patch can't go in at all? This patch doesn't need a copyright assignment. It's far too small. [Otherwise I wouldn't have gone to this trouble...] > Index: cgen-trace.c > =================================================================== > RCS file: /cvs/src/src/sim/common/cgen-trace.c,v > retrieving revision 1.5 > diff -u -p -r1.5 cgen-trace.c > --- cgen-trace.c 23 Dec 2000 21:52:14 -0000 1.5 > +++ cgen-trace.c 18 Jun 2003 05:03:40 -0000 > @@ -322,12 +322,12 @@ sim_disasm_sprintf VPARAMS ((SFILE *f, c > /* Memory read support for an opcodes disassembler. */ > > int > -sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length, > +sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, unsigned int length, > struct disassemble_info *info) > { > SIM_CPU *cpu = (SIM_CPU *) info->application_data; > SIM_DESC sd = CPU_STATE (cpu); > - int length_read; > + unsigned length_read; > > length_read = sim_core_read_buffer (sd, cpu, read_map, myaddr, memaddr, > length); > Index: cgen-trace.h > =================================================================== > RCS file: /cvs/src/src/sim/common/cgen-trace.h,v > retrieving revision 1.2 > diff -u -p -r1.2 cgen-trace.h > --- cgen-trace.h 14 Oct 2002 10:55:39 -0000 1.2 > +++ cgen-trace.h 18 Jun 2003 05:03:40 -0000 > @@ -81,7 +81,7 @@ extern int sim_disasm_sprintf (SFILE *, > #ifdef __BFD_H_SEEN__ > struct disassemble_info; > extern int > -sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, int length_, > +sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, unsigned int length_, > struct disassemble_info *info_); > extern void > sim_disasm_perror_memory (int status_, bfd_vma memaddr_, >