From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11430 invoked by alias); 18 Jun 2003 15:03:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11373 invoked from network); 18 Jun 2003 15:02:58 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 18 Jun 2003 15:02:58 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 48C672B5F; Wed, 18 Jun 2003 11:02:58 -0400 (EDT) Message-ID: <3EF07F22.7040902@redhat.com> Date: Wed, 18 Jun 2003 15:03:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Doug Evans Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] update cgen read_memory_func References: <20030618052001.1214AB536@mail.sebabeach.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00594.txt.bz2 > fyi, I'll be checking this in. > > 2003-06-17 Doug Evans > > * cgen-trace.h (sim_disasm_read_memory): Update args to be compatible > with disassemble_info:read_memory_func. > * cgen-trace.c (sim_disasm_read_memory): Ditto. Doug. Only people with an FSF GDB copyright assignment are permitted to make changes to the FSF's GDB sources. Andrew > Index: cgen-trace.c > =================================================================== > RCS file: /cvs/src/src/sim/common/cgen-trace.c,v > retrieving revision 1.5 > diff -u -p -r1.5 cgen-trace.c > --- cgen-trace.c 23 Dec 2000 21:52:14 -0000 1.5 > +++ cgen-trace.c 18 Jun 2003 05:03:40 -0000 > @@ -322,12 +322,12 @@ sim_disasm_sprintf VPARAMS ((SFILE *f, c > /* Memory read support for an opcodes disassembler. */ > > int > -sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length, > +sim_disasm_read_memory (bfd_vma memaddr, bfd_byte *myaddr, unsigned int length, > struct disassemble_info *info) > { > SIM_CPU *cpu = (SIM_CPU *) info->application_data; > SIM_DESC sd = CPU_STATE (cpu); > - int length_read; > + unsigned length_read; > > length_read = sim_core_read_buffer (sd, cpu, read_map, myaddr, memaddr, > length); > Index: cgen-trace.h > =================================================================== > RCS file: /cvs/src/src/sim/common/cgen-trace.h,v > retrieving revision 1.2 > diff -u -p -r1.2 cgen-trace.h > --- cgen-trace.h 14 Oct 2002 10:55:39 -0000 1.2 > +++ cgen-trace.h 18 Jun 2003 05:03:40 -0000 > @@ -81,7 +81,7 @@ extern int sim_disasm_sprintf (SFILE *, > #ifdef __BFD_H_SEEN__ > struct disassemble_info; > extern int > -sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, int length_, > +sim_disasm_read_memory (bfd_vma memaddr_, bfd_byte *myaddr_, unsigned int length_, > struct disassemble_info *info_); > extern void > sim_disasm_perror_memory (int status_, bfd_vma memaddr_, >