Re: [RFA]: Fix testsuite/gdb.base/break.exp when test compiled with -DPROTOTYPES

[Stephane Carrez <stcarrez@nerim.fr>]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

Hi!

Daniel Jacobowitz wrote:
> On Fri, Apr 04, 2003 at 11:31:37PM +0200, Stephane Carrez wrote:
> 
>>Hi!
>>
>>Michael Elizabeth Chastain wrote:
>>
>>>I could be wrong, but I don't think you can put comments in the
>>>middle of a gdb_expect block like this.
>>>
>>> +    # marker4() is defined at line 46 when compiled with -DPROTOTYPES
>>> +    -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at 
>>> .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" {
>>> +	pass "run until breakpoint set at small function, optimized file"
>>> +    }
>>>
>>>I think you have to do this:
>>>
>>> -re "Breakpoint ... void marker.*" {
>>>   # marker4() is defined at line 46 when compiled with -DPROTOTYPES
>>>   pass "run until breakpoint set at small function, optimized file"
>>> }
>>>
>>>Michael C
>>>
>>>
>>
>>I wasn't sure too..
>>
>>But I verified that it worked before the commit...
> 
> 
> It may have worked, but Michael is right.  It will parse the comment as
> a series of patterns and code blocks.
> 
Ok, it's very bad then.  I've removed the patch.

	Stephane

2003-04-05  Stephane Carrez  <stcarrez@nerim.fr>

	* gdb.base/break.exp: Revert last patch.


[-- Attachment #2: break.exp.diffs --]
[-- Type: text/plain, Size: 920 bytes --]

Index: gdb.base/break.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
retrieving revision 1.15
diff -u -p -r1.15 break.exp
--- gdb.base/break.exp  4 Apr 2003 20:03:46 -0000       1.15
+++ gdb.base/break.exp  5 Apr 2003 10:40:04 -0000
@@ -914,10 +914,6 @@ gdb_expect {
     -re "Breakpoint $decimal, $hex in marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" {
        pass "run until breakpoint set at small function, optimized file"
     }
-    # marker4() is defined at line 46 when compiled with -DPROTOTYPES
-    -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" {
-       pass "run until breakpoint set at small function, optimized file"
-    }
     -re ".*$gdb_prompt " {
        fail "run until breakpoint set at small function, optimized file"
     }