From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27530 invoked by alias); 5 Apr 2003 10:46:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27523 invoked from network); 5 Apr 2003 10:46:52 -0000 Received: from unknown (HELO kraid.nerim.net) (62.4.16.103) by sources.redhat.com with SMTP; 5 Apr 2003 10:46:52 -0000 Received: from nerim.fr (stcarrez.net1.nerim.net [62.212.108.40]) by kraid.nerim.net (Postfix) with ESMTP id 832A840F1B; Sat, 5 Apr 2003 12:46:25 +0200 (CEST) Message-ID: <3E8EB3F4.8040109@nerim.fr> Date: Sat, 05 Apr 2003 10:46:00 -0000 From: Stephane Carrez User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix testsuite/gdb.base/break.exp when test compiled with -DPROTOTYPES References: <200304042041.h34Kf5627351@duracef.shout.net> <3E8DF9B9.4070709@nerim.fr> <20030404222839.GA18941@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------030209030902070301000608" X-SW-Source: 2003-04/txt/msg00075.txt.bz2 This is a multi-part message in MIME format. --------------030209030902070301000608 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1153 Hi! Daniel Jacobowitz wrote: > On Fri, Apr 04, 2003 at 11:31:37PM +0200, Stephane Carrez wrote: > >>Hi! >> >>Michael Elizabeth Chastain wrote: >> >>>I could be wrong, but I don't think you can put comments in the >>>middle of a gdb_expect block like this. >>> >>> + # marker4() is defined at line 46 when compiled with -DPROTOTYPES >>> + -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at >>> .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" { >>> + pass "run until breakpoint set at small function, optimized file" >>> + } >>> >>>I think you have to do this: >>> >>> -re "Breakpoint ... void marker.*" { >>> # marker4() is defined at line 46 when compiled with -DPROTOTYPES >>> pass "run until breakpoint set at small function, optimized file" >>> } >>> >>>Michael C >>> >>> >> >>I wasn't sure too.. >> >>But I verified that it worked before the commit... > > > It may have worked, but Michael is right. It will parse the comment as > a series of patterns and code blocks. > Ok, it's very bad then. I've removed the patch. Stephane 2003-04-05 Stephane Carrez * gdb.base/break.exp: Revert last patch. --------------030209030902070301000608 Content-Type: text/plain; name="break.exp.diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="break.exp.diffs" Content-length: 920 Index: gdb.base/break.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v retrieving revision 1.15 diff -u -p -r1.15 break.exp --- gdb.base/break.exp 4 Apr 2003 20:03:46 -0000 1.15 +++ gdb.base/break.exp 5 Apr 2003 10:40:04 -0000 @@ -914,10 +914,6 @@ gdb_expect { -re "Breakpoint $decimal, $hex in marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" { pass "run until breakpoint set at small function, optimized file" } - # marker4() is defined at line 46 when compiled with -DPROTOTYPES - -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" { - pass "run until breakpoint set at small function, optimized file" - } -re ".*$gdb_prompt " { fail "run until breakpoint set at small function, optimized file" } --------------030209030902070301000608--