Re: [RFA]: Fix testsuite/gdb.base/break.exp when test compiled with -DPROTOTYPES

[Elena Zannoni <ezannoni@redhat.com>]

Stephane Carrez writes:
 > Hi!
 > 
 > In the gdb.base/break.c test, the function marker4() is defined at line 46 when
 > the test is compiled with -DPROTOTYPES and at line 51 otherwise.  The break.exp
 > test only check for line 51.
 > 
 > This patch adds the missing regexp for marker4 at line 46.
 > (tested with make check for m6811-elf; break.exp passes completely)
 > 
 > Can you approve it?
 > 

Could this be fixed by adding a comment to the lines in question,
use gdb_get_line_number, and use that in the test? 

elena

 > Thanks,
 > 	Stephane
 > 
 > 2003-02-24  Stephane Carrez  <stcarrez@nerim.fr>
 > 
 > 	* gdb.base/break.exp: marker4() is defined at line 46 when compiled
 > 	with -DPROTOTYPES.
 > Index: gdb.base/break.exp
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
 > retrieving revision 1.14
 > diff -u -p -r1.14 break.exp
 > --- gdb.base/break.exp	16 Jan 2003 01:56:15 -0000	1.14
 > +++ gdb.base/break.exp	24 Feb 2003 21:13:24 -0000
 > @@ -907,11 +907,16 @@ if ![target_info exists use_gdb_stub] {
 >  # as if it were in the middle of a line rather than at the beginning.
 >  
 >  send_gdb "continue\n"
 > +# marker4() is defined at line 46 when compiled with -DPROTOTYPES
 > +# and at line 51 otherwise.
 >  gdb_expect {
 >      -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" {
 >  	pass "run until breakpoint set at small function, optimized file"
 >      }
 >      -re "Breakpoint $decimal, $hex in marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" {
 > +	pass "run until breakpoint set at small function, optimized file"
 > +    }
 > +    -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" {
 >  	pass "run until breakpoint set at small function, optimized file"
 >      }
 >      -re ".*$gdb_prompt " {