From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-22747-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25873 invoked by alias); 24 Feb 2003 21:34:47 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25866 invoked from network); 24 Feb 2003 21:34:47 -0000
Received: from unknown (HELO mx1.redhat.com) (172.16.49.200)
  by 172.16.49.205 with SMTP; 24 Feb 2003 21:34:47 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h1OLYle04528
	for <gdb-patches@sources.redhat.com>; Mon, 24 Feb 2003 16:34:47 -0500
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1OLYlq14268
	for <gdb-patches@sources.redhat.com>; Mon, 24 Feb 2003 16:34:47 -0500
Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1OLYkI11379
	for <gdb-patches@sources.redhat.com>; Mon, 24 Feb 2003 16:34:46 -0500
Received: by localhost.redhat.com (Postfix, from userid 469)
	id C7513FF79; Mon, 24 Feb 2003 16:38:49 -0500 (EST)
From: Elena Zannoni <ezannoni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15962.37096.719113.658720@localhost.redhat.com>
Date: Mon, 24 Feb 2003 21:34:00 -0000
To: Stephane Carrez <stcarrez@nerim.fr>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: Fix testsuite/gdb.base/break.exp when test compiled with -DPROTOTYPES
In-Reply-To: <3E5A8C4F.7020000@nerim.fr>
References: <3E5A8C4F.7020000@nerim.fr>
X-SW-Source: 2003-02/txt/msg00605.txt.bz2

Stephane Carrez writes:
 > Hi!
 > 
 > In the gdb.base/break.c test, the function marker4() is defined at line 46 when
 > the test is compiled with -DPROTOTYPES and at line 51 otherwise.  The break.exp
 > test only check for line 51.
 > 
 > This patch adds the missing regexp for marker4 at line 46.
 > (tested with make check for m6811-elf; break.exp passes completely)
 > 
 > Can you approve it?
 > 

Could this be fixed by adding a comment to the lines in question,
use gdb_get_line_number, and use that in the test? 

elena

 > Thanks,
 > 	Stephane
 > 
 > 2003-02-24  Stephane Carrez  <stcarrez@nerim.fr>
 > 
 > 	* gdb.base/break.exp: marker4() is defined at line 46 when compiled
 > 	with -DPROTOTYPES.
 > Index: gdb.base/break.exp
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/break.exp,v
 > retrieving revision 1.14
 > diff -u -p -r1.14 break.exp
 > --- gdb.base/break.exp	16 Jan 2003 01:56:15 -0000	1.14
 > +++ gdb.base/break.exp	24 Feb 2003 21:13:24 -0000
 > @@ -907,11 +907,16 @@ if ![target_info exists use_gdb_stub] {
 >  # as if it were in the middle of a line rather than at the beginning.
 >  
 >  send_gdb "continue\n"
 > +# marker4() is defined at line 46 when compiled with -DPROTOTYPES
 > +# and at line 51 otherwise.
 >  gdb_expect {
 >      -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" {
 >  	pass "run until breakpoint set at small function, optimized file"
 >      }
 >      -re "Breakpoint $decimal, $hex in marker4 \\(d=177601976\\) at .*$srcfile:51\[\r\n\]+51\[\t \]+void marker4.*" {
 > +	pass "run until breakpoint set at small function, optimized file"
 > +    }
 > +    -re "Breakpoint $decimal, marker4 \\(d=177601976\\) at .*$srcfile:46\[\r\n\]+46\[\t \]+void marker4.*" {
 >  	pass "run until breakpoint set at small function, optimized file"
 >      }
 >      -re ".*$gdb_prompt " {