[patch rfc] Switch ns32k to CALL_DUMMY_BREAKPOINT_OFFSET

[patch rfc] Switch ns32k to CALL_DUMMY_BREAKPOINT_OFFSET

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hello,

This switches the ns32k target to the CALL_DUMMY_BREAKPOINT_OFFSET 
mechanism.   When using that mechanism, GDB explicitly sets a momentary 
breakpoint at the inferior function call's return address.

The ns32k is the only target that doesn't use that mechanism so doing 
this switch lets GDB expunge a macro.

If course I've no ns32k so this is just an educated guess :-)

Jason, got a machine to test this on?  Or should this be assumed to work?

Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 957 bytes --]

2003-03-29  Andrew Cagney  <cagney@redhat.com>

	* ns32k-tdep.c (ns32k_gdbarch_init): Set the call dummy breakpoint
	offset.

Index: ns32k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v
retrieving revision 1.39
diff -u -r1.39 ns32k-tdep.c
--- ns32k-tdep.c	25 Mar 2003 20:38:46 -0000	1.39
+++ ns32k-tdep.c	29 Mar 2003 18:45:04 -0000
@@ -600,7 +600,8 @@
   set_gdbarch_sizeof_call_dummy_words (gdbarch, sizeof_ns32k_call_dummy_words);
   set_gdbarch_fix_call_dummy (gdbarch, ns32k_fix_call_dummy);
   set_gdbarch_call_dummy_start_offset (gdbarch, 3);
-  set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 0);
+  set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 1);
+  set_gdbarch_call_dummy_breakpoint_offset (gdbarch, 15);
   set_gdbarch_deprecated_use_generic_dummy_frames (gdbarch, 0);
   set_gdbarch_deprecated_pc_in_call_dummy (gdbarch, deprecated_pc_in_call_dummy_on_stack);
 

Re: [patch rfc] Switch ns32k to CALL_DUMMY_BREAKPOINT_OFFSET

[Jason Thorpe]

On Saturday, March 29, 2003, at 10:51  AM, Andrew Cagney wrote:

> Jason, got a machine to test this on?  Or should this be assumed to 
> work?

I'd say go ahead and assume it's okay.  I'm still in the process of 
putting together a PC532 (I finally got a SCSI->Ethernet adapter last 
week so I can hook it up to the network :-)

         -- Jason R. Thorpe <thorpej@wasabisystems.com>

Re: [patch rfc] Switch ns32k to CALL_DUMMY_BREAKPOINT_OFFSET

[Andrew Cagney]

> 
> On Saturday, March 29, 2003, at 10:51  AM, Andrew Cagney wrote:
> 
> > Jason, got a machine to test this on?  Or should this be assumed to work?
> 
> I'd say go ahead and assume it's okay.  I'm still in the process of putting together a PC532 (I finally got a SCSI->Ethernet adapter last week so I can hook it up to the network :-)

Ok, in it goes.  No marks for anyone that guesses what the next patch is 
....

thanks
Andrew