Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: gdb-patches@sources.redhat.com,
	Jason R Thorpe <thorpej@wasabisystems.com>
Subject: [patch rfc] Switch ns32k to CALL_DUMMY_BREAKPOINT_OFFSET
Date: Sat, 29 Mar 2003 18:52:00 -0000	[thread overview]
Message-ID: <3E85EB47.1080108@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hello,

This switches the ns32k target to the CALL_DUMMY_BREAKPOINT_OFFSET 
mechanism.   When using that mechanism, GDB explicitly sets a momentary 
breakpoint at the inferior function call's return address.

The ns32k is the only target that doesn't use that mechanism so doing 
this switch lets GDB expunge a macro.

If course I've no ns32k so this is just an educated guess :-)

Jason, got a machine to test this on?  Or should this be assumed to work?

Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 957 bytes --]

2003-03-29  Andrew Cagney  <cagney@redhat.com>

	* ns32k-tdep.c (ns32k_gdbarch_init): Set the call dummy breakpoint
	offset.

Index: ns32k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v
retrieving revision 1.39
diff -u -r1.39 ns32k-tdep.c
--- ns32k-tdep.c	25 Mar 2003 20:38:46 -0000	1.39
+++ ns32k-tdep.c	29 Mar 2003 18:45:04 -0000
@@ -600,7 +600,8 @@
   set_gdbarch_sizeof_call_dummy_words (gdbarch, sizeof_ns32k_call_dummy_words);
   set_gdbarch_fix_call_dummy (gdbarch, ns32k_fix_call_dummy);
   set_gdbarch_call_dummy_start_offset (gdbarch, 3);
-  set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 0);
+  set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 1);
+  set_gdbarch_call_dummy_breakpoint_offset (gdbarch, 15);
   set_gdbarch_deprecated_use_generic_dummy_frames (gdbarch, 0);
   set_gdbarch_deprecated_pc_in_call_dummy (gdbarch, deprecated_pc_in_call_dummy_on_stack);
 

             reply	other threads:[~2003-03-29 18:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-29 18:52 Andrew Cagney [this message]
2003-03-29 20:24 ` Jason Thorpe
2003-03-29 22:14   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E85EB47.1080108@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=thorpej@wasabisystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox