From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23616 invoked by alias); 29 Mar 2003 18:52:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23608 invoked from network); 29 Mar 2003 18:52:02 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 29 Mar 2003 18:52:02 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 61E8A2B23; Sat, 29 Mar 2003 13:51:51 -0500 (EST) Message-ID: <3E85EB47.1080108@redhat.com> Date: Sat, 29 Mar 2003 18:52:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, Jason R Thorpe Subject: [patch rfc] Switch ns32k to CALL_DUMMY_BREAKPOINT_OFFSET Content-Type: multipart/mixed; boundary="------------090207060108090607020100" X-SW-Source: 2003-03/txt/msg00578.txt.bz2 This is a multi-part message in MIME format. --------------090207060108090607020100 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 464 Hello, This switches the ns32k target to the CALL_DUMMY_BREAKPOINT_OFFSET mechanism. When using that mechanism, GDB explicitly sets a momentary breakpoint at the inferior function call's return address. The ns32k is the only target that doesn't use that mechanism so doing this switch lets GDB expunge a macro. If course I've no ns32k so this is just an educated guess :-) Jason, got a machine to test this on? Or should this be assumed to work? Andrew --------------090207060108090607020100 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 957 2003-03-29 Andrew Cagney * ns32k-tdep.c (ns32k_gdbarch_init): Set the call dummy breakpoint offset. Index: ns32k-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v retrieving revision 1.39 diff -u -r1.39 ns32k-tdep.c --- ns32k-tdep.c 25 Mar 2003 20:38:46 -0000 1.39 +++ ns32k-tdep.c 29 Mar 2003 18:45:04 -0000 @@ -600,7 +600,8 @@ set_gdbarch_sizeof_call_dummy_words (gdbarch, sizeof_ns32k_call_dummy_words); set_gdbarch_fix_call_dummy (gdbarch, ns32k_fix_call_dummy); set_gdbarch_call_dummy_start_offset (gdbarch, 3); - set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 0); + set_gdbarch_call_dummy_breakpoint_offset_p (gdbarch, 1); + set_gdbarch_call_dummy_breakpoint_offset (gdbarch, 15); set_gdbarch_deprecated_use_generic_dummy_frames (gdbarch, 0); set_gdbarch_deprecated_pc_in_call_dummy (gdbarch, deprecated_pc_in_call_dummy_on_stack); --------------090207060108090607020100--