* [RFA] Have ObjC shared the cplus_specific struct
@ 2003-02-18 3:45 Adam Fedor
2003-02-18 15:42 ` Adam Fedor
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Adam Fedor @ 2003-02-18 3:45 UTC (permalink / raw)
To: GDB Patches
[-- Attachment #1: Type: text/plain, Size: 87 bytes --]
This patch removes the objc_specific struct and uses the cplus_specific
one instead.
[-- Attachment #2: symtab.patch --]
[-- Type: text/plain, Size: 2356 bytes --]
2003-02-17 Adam Fedor <fedor@gnu.org>
* symtab.h: Remove objc_specific struct
* symtab.c (symbol_init_language_specific,
symbol_init_demangled_name, symbol_demangled_name): Have
language_objc use cplus_specific struct.
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.87
diff -u -p -r1.87 symtab.c
--- symtab.c 4 Feb 2003 18:07:01 -0000 1.87
+++ symtab.c 18 Feb 2003 03:17:46 -0000
@@ -412,14 +413,11 @@ symbol_init_language_specific (struct ge
{
gsymbol->language = language;
if (gsymbol->language == language_cplus
- || gsymbol->language == language_java)
+ || gsymbol->language == language_java
+ || gsymbol->language == language_objc)
{
gsymbol->language_specific.cplus_specific.demangled_name = NULL;
}
- else if (gsymbol->language == language_objc)
- {
- gsymbol->language_specific.objc_specific.demangled_name = NULL;
- }
else
{
memset (&gsymbol->language_specific, 0,
@@ -558,7 +568,8 @@ symbol_init_demangled_name (struct gener
demangled = symbol_find_demangled_name (gsymbol, mangled);
if (gsymbol->language == language_cplus
- || gsymbol->language == language_java)
+ || gsymbol->language == language_java
+ || gsymbol->language == language_objc)
{
if (demangled)
{
@@ -583,12 +594,10 @@ char *
symbol_demangled_name (struct general_symbol_info *gsymbol)
{
if (gsymbol->language == language_cplus
- || gsymbol->language == language_java)
+ || gsymbol->language == language_java
+ || gsymbol->language == language_objc)
return gsymbol->language_specific.cplus_specific.demangled_name;
- else if (gsymbol->language == language_objc)
- return gsymbol->language_specific.objc_specific.demangled_name;
-
else
return NULL;
}
Index: symtab.h
===================================================================
RCS file: /cvs/src/src/gdb/symtab.h,v
retrieving revision 1.57
diff -u -p -r1.57 symtab.h
--- symtab.h 4 Feb 2003 21:37:03 -0000 1.57
+++ symtab.h 14 Feb 2003 04:24:44 -0000
@@ -90,11 +90,6 @@ struct general_symbol_info
char *demangled_name;
}
cplus_specific;
- struct objc_specific
- {
- char *demangled_name;
- }
- objc_specific;
}
language_specific;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Have ObjC shared the cplus_specific struct
2003-02-18 3:45 [RFA] Have ObjC shared the cplus_specific struct Adam Fedor
@ 2003-02-18 15:42 ` Adam Fedor
2003-02-19 15:08 ` Elena Zannoni
2003-02-19 18:56 ` Elena Zannoni
2 siblings, 0 replies; 5+ messages in thread
From: Adam Fedor @ 2003-02-18 15:42 UTC (permalink / raw)
To: GDB Patches
Adam Fedor wrote:
> This patch removes the objc_specific struct and uses the cplus_specific
> one instead.
>
>
> ------------------------------------------------------------------------
>
> 2003-02-17 Adam Fedor <fedor@gnu.org>
>
> * symtab.h: Remove objc_specific struct
> * symtab.c (symbol_init_language_specific,
> symbol_init_demangled_name, symbol_demangled_name): Have
> language_objc use cplus_specific struct.
>
> @@ -558,7 +568,8 @@ symbol_init_demangled_name (struct gener
>
> demangled = symbol_find_demangled_name (gsymbol, mangled);
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> {
> if (demangled)
> {
Minor oops. This part of the patch is actually supposed to go with my
other patch to demangle objc names. See PR 1066 or
http://sources.redhat.com/ml/gdb-patches/2003-01/msg00442.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Have ObjC shared the cplus_specific struct
2003-02-18 3:45 [RFA] Have ObjC shared the cplus_specific struct Adam Fedor
2003-02-18 15:42 ` Adam Fedor
@ 2003-02-19 15:08 ` Elena Zannoni
2003-02-20 3:40 ` Adam Fedor
2003-02-19 18:56 ` Elena Zannoni
2 siblings, 1 reply; 5+ messages in thread
From: Elena Zannoni @ 2003-02-19 15:08 UTC (permalink / raw)
To: Adam Fedor; +Cc: GDB Patches
Adam Fedor writes:
> This patch removes the objc_specific struct and uses the cplus_specific
> one instead.
OK.
Is there a PR associated with this?
elena
>
> 2003-02-17 Adam Fedor <fedor@gnu.org>
>
> * symtab.h: Remove objc_specific struct
> * symtab.c (symbol_init_language_specific,
> symbol_init_demangled_name, symbol_demangled_name): Have
> language_objc use cplus_specific struct.
>
> Index: symtab.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.c,v
> retrieving revision 1.87
> diff -u -p -r1.87 symtab.c
> --- symtab.c 4 Feb 2003 18:07:01 -0000 1.87
> +++ symtab.c 18 Feb 2003 03:17:46 -0000
> @@ -412,14 +413,11 @@ symbol_init_language_specific (struct ge
> {
> gsymbol->language = language;
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> {
> gsymbol->language_specific.cplus_specific.demangled_name = NULL;
> }
> - else if (gsymbol->language == language_objc)
> - {
> - gsymbol->language_specific.objc_specific.demangled_name = NULL;
> - }
> else
> {
> memset (&gsymbol->language_specific, 0,
> @@ -558,7 +568,8 @@ symbol_init_demangled_name (struct gener
>
> demangled = symbol_find_demangled_name (gsymbol, mangled);
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> {
> if (demangled)
> {
> @@ -583,12 +594,10 @@ char *
> symbol_demangled_name (struct general_symbol_info *gsymbol)
> {
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> return gsymbol->language_specific.cplus_specific.demangled_name;
>
> - else if (gsymbol->language == language_objc)
> - return gsymbol->language_specific.objc_specific.demangled_name;
> -
> else
> return NULL;
> }
> Index: symtab.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.h,v
> retrieving revision 1.57
> diff -u -p -r1.57 symtab.h
> --- symtab.h 4 Feb 2003 21:37:03 -0000 1.57
> +++ symtab.h 14 Feb 2003 04:24:44 -0000
> @@ -90,11 +90,6 @@ struct general_symbol_info
> char *demangled_name;
> }
> cplus_specific;
> - struct objc_specific
> - {
> - char *demangled_name;
> - }
> - objc_specific;
> }
> language_specific;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Have ObjC shared the cplus_specific struct
2003-02-18 3:45 [RFA] Have ObjC shared the cplus_specific struct Adam Fedor
2003-02-18 15:42 ` Adam Fedor
2003-02-19 15:08 ` Elena Zannoni
@ 2003-02-19 18:56 ` Elena Zannoni
2 siblings, 0 replies; 5+ messages in thread
From: Elena Zannoni @ 2003-02-19 18:56 UTC (permalink / raw)
To: Adam Fedor; +Cc: GDB Patches
Adam Fedor writes:
> This patch removes the objc_specific struct and uses the cplus_specific
> one instead.
>
OK.
elena
> 2003-02-17 Adam Fedor <fedor@gnu.org>
>
> * symtab.h: Remove objc_specific struct
> * symtab.c (symbol_init_language_specific,
> symbol_init_demangled_name, symbol_demangled_name): Have
> language_objc use cplus_specific struct.
>
> Index: symtab.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.c,v
> retrieving revision 1.87
> diff -u -p -r1.87 symtab.c
> --- symtab.c 4 Feb 2003 18:07:01 -0000 1.87
> +++ symtab.c 18 Feb 2003 03:17:46 -0000
> @@ -412,14 +413,11 @@ symbol_init_language_specific (struct ge
> {
> gsymbol->language = language;
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> {
> gsymbol->language_specific.cplus_specific.demangled_name = NULL;
> }
> - else if (gsymbol->language == language_objc)
> - {
> - gsymbol->language_specific.objc_specific.demangled_name = NULL;
> - }
> else
> {
> memset (&gsymbol->language_specific, 0,
> @@ -558,7 +568,8 @@ symbol_init_demangled_name (struct gener
>
> demangled = symbol_find_demangled_name (gsymbol, mangled);
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> {
> if (demangled)
> {
> @@ -583,12 +594,10 @@ char *
> symbol_demangled_name (struct general_symbol_info *gsymbol)
> {
> if (gsymbol->language == language_cplus
> - || gsymbol->language == language_java)
> + || gsymbol->language == language_java
> + || gsymbol->language == language_objc)
> return gsymbol->language_specific.cplus_specific.demangled_name;
>
> - else if (gsymbol->language == language_objc)
> - return gsymbol->language_specific.objc_specific.demangled_name;
> -
> else
> return NULL;
> }
> Index: symtab.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.h,v
> retrieving revision 1.57
> diff -u -p -r1.57 symtab.h
> --- symtab.h 4 Feb 2003 21:37:03 -0000 1.57
> +++ symtab.h 14 Feb 2003 04:24:44 -0000
> @@ -90,11 +90,6 @@ struct general_symbol_info
> char *demangled_name;
> }
> cplus_specific;
> - struct objc_specific
> - {
> - char *demangled_name;
> - }
> - objc_specific;
> }
> language_specific;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFA] Have ObjC shared the cplus_specific struct
2003-02-19 15:08 ` Elena Zannoni
@ 2003-02-20 3:40 ` Adam Fedor
0 siblings, 0 replies; 5+ messages in thread
From: Adam Fedor @ 2003-02-20 3:40 UTC (permalink / raw)
To: Elena Zannoni; +Cc: GDB Patches
Elena Zannoni wrote:
> Adam Fedor writes:
> > This patch removes the objc_specific struct and uses the cplus_specific
> > one instead.
>
> OK.
> Is there a PR associated with this?
>
No.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-02-20 3:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-18 3:45 [RFA] Have ObjC shared the cplus_specific struct Adam Fedor
2003-02-18 15:42 ` Adam Fedor
2003-02-19 15:08 ` Elena Zannoni
2003-02-20 3:40 ` Adam Fedor
2003-02-19 18:56 ` Elena Zannoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox