From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18941 invoked by alias); 19 Feb 2003 15:08:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18931 invoked from network); 19 Feb 2003 15:08:32 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 19 Feb 2003 15:08:32 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h1JF8WK32520 for ; Wed, 19 Feb 2003 10:08:32 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1JF8Wa27493 for ; Wed, 19 Feb 2003 10:08:32 -0500 Received: from localhost.redhat.com (romulus-int.sfbay.redhat.com [172.16.27.46]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1JF8V503875 for ; Wed, 19 Feb 2003 10:08:31 -0500 Received: by localhost.redhat.com (Postfix, from userid 469) id 493F1FF79; Wed, 19 Feb 2003 10:12:38 -0500 (EST) From: Elena Zannoni MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15955.40678.132629.275547@localhost.redhat.com> Date: Wed, 19 Feb 2003 15:08:00 -0000 To: Adam Fedor Cc: GDB Patches Subject: Re: [RFA] Have ObjC shared the cplus_specific struct In-Reply-To: <3E51AC66.3060704@doc.com> References: <3E51AC66.3060704@doc.com> X-SW-Source: 2003-02/txt/msg00404.txt.bz2 Adam Fedor writes: > This patch removes the objc_specific struct and uses the cplus_specific > one instead. OK. Is there a PR associated with this? elena > > 2003-02-17 Adam Fedor > > * symtab.h: Remove objc_specific struct > * symtab.c (symbol_init_language_specific, > symbol_init_demangled_name, symbol_demangled_name): Have > language_objc use cplus_specific struct. > > Index: symtab.c > =================================================================== > RCS file: /cvs/src/src/gdb/symtab.c,v > retrieving revision 1.87 > diff -u -p -r1.87 symtab.c > --- symtab.c 4 Feb 2003 18:07:01 -0000 1.87 > +++ symtab.c 18 Feb 2003 03:17:46 -0000 > @@ -412,14 +413,11 @@ symbol_init_language_specific (struct ge > { > gsymbol->language = language; > if (gsymbol->language == language_cplus > - || gsymbol->language == language_java) > + || gsymbol->language == language_java > + || gsymbol->language == language_objc) > { > gsymbol->language_specific.cplus_specific.demangled_name = NULL; > } > - else if (gsymbol->language == language_objc) > - { > - gsymbol->language_specific.objc_specific.demangled_name = NULL; > - } > else > { > memset (&gsymbol->language_specific, 0, > @@ -558,7 +568,8 @@ symbol_init_demangled_name (struct gener > > demangled = symbol_find_demangled_name (gsymbol, mangled); > if (gsymbol->language == language_cplus > - || gsymbol->language == language_java) > + || gsymbol->language == language_java > + || gsymbol->language == language_objc) > { > if (demangled) > { > @@ -583,12 +594,10 @@ char * > symbol_demangled_name (struct general_symbol_info *gsymbol) > { > if (gsymbol->language == language_cplus > - || gsymbol->language == language_java) > + || gsymbol->language == language_java > + || gsymbol->language == language_objc) > return gsymbol->language_specific.cplus_specific.demangled_name; > > - else if (gsymbol->language == language_objc) > - return gsymbol->language_specific.objc_specific.demangled_name; > - > else > return NULL; > } > Index: symtab.h > =================================================================== > RCS file: /cvs/src/src/gdb/symtab.h,v > retrieving revision 1.57 > diff -u -p -r1.57 symtab.h > --- symtab.h 4 Feb 2003 21:37:03 -0000 1.57 > +++ symtab.h 14 Feb 2003 04:24:44 -0000 > @@ -90,11 +90,6 @@ struct general_symbol_info > char *demangled_name; > } > cplus_specific; > - struct objc_specific > - { > - char *demangled_name; > - } > - objc_specific; > } > language_specific; >