From: Michael Snyder <msnyder@redhat.com>
To: Kazu Hirata <kazu@cs.umass.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Unreviewed patches
Date: Fri, 31 Jan 2003 02:36:00 -0000 [thread overview]
Message-ID: <3E39E145.A5B01D17@redhat.com> (raw)
In-Reply-To: <20030130.010258.25912168.kazu@cs.umass.edu>
Kazu Hirata wrote:
>
> Hi,
>
> If somebody could review these patches, that would be greatly
> appreciated.
>
> [RFA] sim/h8300/h8300.c: Fix the handling of bxor.
> http://sources.redhat.com/ml/gdb-patches/2003-01/msg00328.html
For this one, I find the expression "!!(ea & m)" a bit obscure.
How about "(ea & m) != 0)"?
> [RFA] sim/h8300/compile.c: Fix the handling of extu.w.
> http://sources.redhat.com/ml/gdb-patches/2002-12/msg00685.html
When you say "an 8-bit wide register that does not exist",
do you mean "that isn't simulated"? It seems to me that
the more correct solution is that breg[] is not big enough.
It ought to be at least 24 words, if not 32.
What do you think?
Michael
next prev parent reply other threads:[~2003-01-31 2:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-30 6:03 Kazu Hirata
2003-01-31 2:36 ` Michael Snyder [this message]
2003-01-31 4:54 ` Kazu Hirata
2003-02-01 1:27 ` Michael Snyder
2003-02-01 3:23 ` Kazu Hirata
2003-02-03 20:30 ` Michael Snyder
2003-02-03 23:30 ` Kazu Hirata
2003-02-05 22:41 ` Michael Snyder
-- strict thread matches above, loose matches on Subject: below --
2007-10-11 14:51 Kazu Hirata
2007-10-04 12:04 Kazu Hirata
2003-01-17 4:33 Kazu Hirata
2002-07-01 6:55 Joern Rennecke
2002-07-01 8:47 ` Elena Zannoni
2002-07-01 10:10 ` Joern Rennecke
2002-07-01 14:24 ` Elena Zannoni
2002-07-01 15:01 ` Joern Rennecke
2002-07-02 12:32 ` Elena Zannoni
2002-07-03 13:49 ` Joern Rennecke
2002-07-12 4:59 ` Elena Zannoni
2002-07-12 5:47 ` Joern Rennecke
2002-07-12 8:23 ` Andrew Cagney
2002-07-17 11:30 ` Joern Rennecke
2002-07-17 13:04 ` Andrew Cagney
2002-08-05 6:47 ` Elena Zannoni
2002-07-12 11:36 ` Elena Zannoni
2002-06-19 14:29 Joern Rennecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E39E145.A5B01D17@redhat.com \
--to=msnyder@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kazu@cs.umass.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox