Re: Unreviewed patches

[Elena Zannoni <ezannoni@redhat.com>]

Joern Rennecke writes:
 > Elena Zannoni wrote:
 > > OK, I see what you are saying, but I don't think that removing the overlaps
 > > from the gdb<->sim interface necessarily forces you to remove the overlaps
 > > from inside the simulator.
 > 
 > You have a point here.  The translation is quite arbitrary.
 > 
 > > It just cleans up the sim_fetch_register and sim_store_register code.
 > 
 > It also changes the interface.
 > 
 > > I am not sure I understand your claim about compatibility. You mean
 > > older gdb's with new sims? That cannot happen. Or you mean the layout
 > 
 > Older gdb's with new sims, or older sims with new gdb's.
 > 

Hmm, I don't think we ever worried about that. We have broken
compatibility even between gcc and gdb, sometimes. And here the chance
is smaller, given that sim and gdb come from the same repo and are
built and linked together.

 > Why should it be safe to have different register numbers in the interface
 > to the same simulator of a slightly different vintage, yet unsafe to
 > have different meanings for the same register numbers in the sh vs. sh64
 > simulator? 
 > 

I think that this is the opportunity to create a clean(er) interface,
and we should do it right. (I was actually commenting on the sh
numbering, not the sh64 yet).

BTW, there is an example of gdb-to-sim-regnum translation in the d10v:
d10v_ts2_register_sim_regno and d10v_ts3_register_sim_regno.


 > >  > > I think the changes below depend on the cgen patches being accepted first.
 > >  >
 > >  > They have.
 > >  >
 > > 
 > > I don't see any replies to your message to the cgen/gdb-patches lists.
 > 
 > Still, when you look at ChangeLog and cpu/{sh64-compact.cpu,sh64-media.cpu},
 > you'll see that Ben Elliston has applied my patch.
 > 

Oh, yes, I see them. I guess they don't reply with 'accepted' in the
cgen world.
But I cannot approve changes to the sh64 sim.

Elena


 > -- 
 > --------------------------
 > SuperH
 > 2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ
 > T:+44 1454 462330