From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-22109-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 15597 invoked by alias); 31 Jan 2003 02:36:55 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15590 invoked from network); 31 Jan 2003 02:36:55 -0000
Received: from unknown (HELO mx1.redhat.com) (172.16.49.200)
  by 172.16.49.205 with SMTP; 31 Jan 2003 02:36:55 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0V2atf10988
	for <gdb-patches@sources.redhat.com>; Thu, 30 Jan 2003 21:36:55 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0V2asn25492;
	Thu, 30 Jan 2003 21:36:54 -0500
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h0V2arw29235;
	Thu, 30 Jan 2003 18:36:53 -0800
Message-ID: <3E39E145.A5B01D17@redhat.com>
Date: Fri, 31 Jan 2003 02:36:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Kazu Hirata <kazu@cs.umass.edu>
CC: gdb-patches@sources.redhat.com
Subject: Re: Unreviewed patches
References: <20030130.010258.25912168.kazu@cs.umass.edu>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-01/txt/msg00824.txt.bz2

Kazu Hirata wrote:
> 
> Hi,
> 
> If somebody could review these patches, that would be greatly
> appreciated.
> 
> [RFA] sim/h8300/h8300.c: Fix the handling of bxor.
> http://sources.redhat.com/ml/gdb-patches/2003-01/msg00328.html

For this one, I find the expression "!!(ea & m)" a bit obscure.
How about "(ea & m) != 0)"?


> [RFA] sim/h8300/compile.c: Fix the handling of extu.w.
> http://sources.redhat.com/ml/gdb-patches/2002-12/msg00685.html

When you say "an 8-bit wide register that does not exist", 
do you mean "that isn't simulated"?  It seems to me that 
the more correct solution is that breg[] is not big enough.
It ought to be at least 24 words, if not 32.

What do you think?

Michael