Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage
Date: Thu, 23 Jan 2003 21:00:00 -0000	[thread overview]
Message-ID: <3E3057F0.5000906@redhat.com> (raw)
In-Reply-To: <1030123072642.ZM24777@localhost.localdomain>

> Without the following patch in place, I've found that inferior function
> calls are badly broken for the mips linux targets that I've been testing.
> (The warning in heuristic_proc_start() is tripped and things degrade quickly
> from there...)
> 
> Okay?
> 
> 	* mips-tdep.c (find_proc_desc): Return early if in a dummy frame.

Hmm, explicit tests for PC in call-dummy set of alarm bells.

Kevin, can you post a backtrace showing how the program came to be 
there?  Two alternative possabilities (in addition to this patch) are:

- the code should not have been called (and the dummy-frame flow should 
have gone elsewhere)

- the code needs to be made per-frame

Andrew


> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.160
> diff -u -p -r1.160 mips-tdep.c
> --- mips-tdep.c	19 Jan 2003 04:06:46 -0000	1.160
> +++ mips-tdep.c	23 Jan 2003 07:20:26 -0000
> @@ -2350,6 +2350,9 @@ find_proc_desc (CORE_ADDR pc, struct fra
>    mips_extra_func_info_t proc_desc;
>    CORE_ADDR startaddr = 0;
>  
> +  if (pc_in_dummy_frame (pc))
> +    return NULL;
> +
>    proc_desc = non_heuristic_proc_desc (pc, &startaddr);
>  
>    if (proc_desc)
> 



  parent reply	other threads:[~2003-01-23 21:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23  7:26 Kevin Buettner
2003-01-23 17:00 ` Daniel Jacobowitz
2003-01-23 21:00 ` Andrew Cagney [this message]
2003-01-23 22:42   ` Daniel Jacobowitz
2003-01-24  3:55   ` Kevin Buettner
2003-01-27 19:21     ` Andrew Cagney
2003-01-27 19:57       ` Kevin Buettner
2003-01-27 22:59         ` Andrew Cagney
2003-01-27 23:57           ` Kevin Buettner
2003-01-28 13:14             ` Andrew Cagney
2003-01-28 16:32               ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E3057F0.5000906@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox