From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29307 invoked by alias); 23 Jan 2003 21:00:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29300 invoked from network); 23 Jan 2003 21:00:33 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by 172.16.49.205 with SMTP; 23 Jan 2003 21:00:33 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E740D3F3A; Thu, 23 Jan 2003 16:00:32 -0500 (EST) Message-ID: <3E3057F0.5000906@redhat.com> Date: Thu, 23 Jan 2003 21:00:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner , gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage References: <1030123072642.ZM24777@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00701.txt.bz2 > Without the following patch in place, I've found that inferior function > calls are badly broken for the mips linux targets that I've been testing. > (The warning in heuristic_proc_start() is tripped and things degrade quickly > from there...) > > Okay? > > * mips-tdep.c (find_proc_desc): Return early if in a dummy frame. Hmm, explicit tests for PC in call-dummy set of alarm bells. Kevin, can you post a backtrace showing how the program came to be there? Two alternative possabilities (in addition to this patch) are: - the code should not have been called (and the dummy-frame flow should have gone elsewhere) - the code needs to be made per-frame Andrew > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.160 > diff -u -p -r1.160 mips-tdep.c > --- mips-tdep.c 19 Jan 2003 04:06:46 -0000 1.160 > +++ mips-tdep.c 23 Jan 2003 07:20:26 -0000 > @@ -2350,6 +2350,9 @@ find_proc_desc (CORE_ADDR pc, struct fra > mips_extra_func_info_t proc_desc; > CORE_ADDR startaddr = 0; > > + if (pc_in_dummy_frame (pc)) > + return NULL; > + > proc_desc = non_heuristic_proc_desc (pc, &startaddr); > > if (proc_desc) >