Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage
Date: Mon, 27 Jan 2003 23:57:00 -0000	[thread overview]
Message-ID: <1030127235721.ZM2609@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "Re: [RFA] mips-tdep.c: Fix inferior function call breakage" (Jan 27,  5:58pm)

On Jan 27,  5:58pm, Andrew Cagney wrote:

> I can see two options:
> 
> - Modify get_prev_frame() to not call init extra info when in a dummy 
> frame.  Not to sure about this.

This might be okay, but it needs to be studied.

> - Modify mips_init_extra_frame_info() to return immediatly when a dummy 
> frame.

I'm more confident in this solution.  See below.  Okay?

	* mips-tdep.c (mips_init_extra_frame_info): Return early for
	dummy frames.

Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.160
diff -u -p -r1.160 mips-tdep.c
--- mips-tdep.c	19 Jan 2003 04:06:46 -0000	1.160
+++ mips-tdep.c	27 Jan 2003 23:51:21 -0000
@@ -2468,9 +2468,13 @@ static void
 mips_init_extra_frame_info (int fromleaf, struct frame_info *fci)
 {
   int regnum;
+  mips_extra_func_info_t proc_desc;
+
+  if (get_frame_type (fci) == DUMMY_FRAME)
+    return;
 
   /* Use proc_desc calculated in frame_chain */
-  mips_extra_func_info_t proc_desc =
+  proc_desc =
     get_next_frame (fci)
     ? cached_proc_desc
     : find_proc_desc (get_frame_pc (fci), get_next_frame (fci), 1);


  reply	other threads:[~2003-01-27 23:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23  7:26 Kevin Buettner
2003-01-23 17:00 ` Daniel Jacobowitz
2003-01-23 21:00 ` Andrew Cagney
2003-01-23 22:42   ` Daniel Jacobowitz
2003-01-24  3:55   ` Kevin Buettner
2003-01-27 19:21     ` Andrew Cagney
2003-01-27 19:57       ` Kevin Buettner
2003-01-27 22:59         ` Andrew Cagney
2003-01-27 23:57           ` Kevin Buettner [this message]
2003-01-28 13:14             ` Andrew Cagney
2003-01-28 16:32               ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030127235721.ZM2609@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox