Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage
Date: Thu, 23 Jan 2003 17:00:00 -0000	[thread overview]
Message-ID: <20030123170115.GA29268@nevyn.them.org> (raw)
In-Reply-To: <1030123072642.ZM24777@localhost.localdomain>

On Thu, Jan 23, 2003 at 12:26:43AM -0700, Kevin Buettner wrote:
> Without the following patch in place, I've found that inferior function
> calls are badly broken for the mips linux targets that I've been testing.
> (The warning in heuristic_proc_start() is tripped and things degrade quickly
> from there...)
> 
> Okay?

In the pile of MIPS patches I really need to get around to submitting
(sorry!) I did this via avoiding the call to find_proc_desc from
mips_init_extra_frame_info.  I think that's functionally equivalent, so
this looks good to me (although Andrew's the one that needs to approve
it of course).

I also short-circuited the rest of mips_init_extra_frame_info if
PC_IN_CALL_DUMMY but that's a noop given the control flow in that
function if proc_desc is NULL.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-01-23 17:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-23  7:26 Kevin Buettner
2003-01-23 17:00 ` Daniel Jacobowitz [this message]
2003-01-23 21:00 ` Andrew Cagney
2003-01-23 22:42   ` Daniel Jacobowitz
2003-01-24  3:55   ` Kevin Buettner
2003-01-27 19:21     ` Andrew Cagney
2003-01-27 19:57       ` Kevin Buettner
2003-01-27 22:59         ` Andrew Cagney
2003-01-27 23:57           ` Kevin Buettner
2003-01-28 13:14             ` Andrew Cagney
2003-01-28 16:32               ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030123170115.GA29268@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox