From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9366 invoked by alias); 23 Jan 2003 17:00:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9357 invoked from network); 23 Jan 2003 17:00:58 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by 172.16.49.205 with SMTP; 23 Jan 2003 17:00:58 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18bmbh-00087m-00 for ; Thu, 23 Jan 2003 13:01:45 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18bkj5-0007de-00 for ; Thu, 23 Jan 2003 12:01:15 -0500 Date: Thu, 23 Jan 2003 17:00:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage Message-ID: <20030123170115.GA29268@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <1030123072642.ZM24777@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1030123072642.ZM24777@localhost.localdomain> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-01/txt/msg00695.txt.bz2 On Thu, Jan 23, 2003 at 12:26:43AM -0700, Kevin Buettner wrote: > Without the following patch in place, I've found that inferior function > calls are badly broken for the mips linux targets that I've been testing. > (The warning in heuristic_proc_start() is tripped and things degrade quickly > from there...) > > Okay? In the pile of MIPS patches I really need to get around to submitting (sorry!) I did this via avoiding the call to find_proc_desc from mips_init_extra_frame_info. I think that's functionally equivalent, so this looks good to me (although Andrew's the one that needs to approve it of course). I also short-circuited the rest of mips_init_extra_frame_info if PC_IN_CALL_DUMMY but that's a noop given the control flow in that function if proc_desc is NULL. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer