From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11228 invoked by alias); 27 Jan 2003 23:57:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11211 invoked from network); 27 Jan 2003 23:57:29 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 27 Jan 2003 23:57:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0RNSFf14133 for ; Mon, 27 Jan 2003 18:28:15 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0RNvRa16076; Mon, 27 Jan 2003 18:57:27 -0500 Received: from localhost.localdomain (vpn50-39.rdu.redhat.com [172.16.50.39]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0RNvQt28291; Mon, 27 Jan 2003 18:57:26 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h0RNvLv02610; Mon, 27 Jan 2003 16:57:21 -0700 Date: Mon, 27 Jan 2003 23:57:00 -0000 From: Kevin Buettner Message-Id: <1030127235721.ZM2609@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [RFA] mips-tdep.c: Fix inferior function call breakage" (Jan 27, 5:58pm) References: <1030123072642.ZM24777@localhost.localdomain> <3E3057F0.5000906@redhat.com> <1030124035453.ZM29667@localhost.localdomain> <3E3586B9.9080100@redhat.com> <1030127195746.ZM23807@localhost.localdomain> <3E35B9B2.5060104@redhat.com> To: Andrew Cagney Subject: Re: [RFA] mips-tdep.c: Fix inferior function call breakage Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-01/txt/msg00749.txt.bz2 On Jan 27, 5:58pm, Andrew Cagney wrote: > I can see two options: > > - Modify get_prev_frame() to not call init extra info when in a dummy > frame. Not to sure about this. This might be okay, but it needs to be studied. > - Modify mips_init_extra_frame_info() to return immediatly when a dummy > frame. I'm more confident in this solution. See below. Okay? * mips-tdep.c (mips_init_extra_frame_info): Return early for dummy frames. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.160 diff -u -p -r1.160 mips-tdep.c --- mips-tdep.c 19 Jan 2003 04:06:46 -0000 1.160 +++ mips-tdep.c 27 Jan 2003 23:51:21 -0000 @@ -2468,9 +2468,13 @@ static void mips_init_extra_frame_info (int fromleaf, struct frame_info *fci) { int regnum; + mips_extra_func_info_t proc_desc; + + if (get_frame_type (fci) == DUMMY_FRAME) + return; /* Use proc_desc calculated in frame_chain */ - mips_extra_func_info_t proc_desc = + proc_desc = get_next_frame (fci) ? cached_proc_desc : find_proc_desc (get_frame_pc (fci), get_next_frame (fci), 1);