[in/5.3] Fix some more build warnings

[in/5.3] Fix some more build warnings

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

FYI,

I've checked this in to the 5.3 branch, an equivalent patch was 
committed to the mainline long ago.  Just that no one noticed :-/

enjoy,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 6797 bytes --]

2002-11-25  Andrew Cagney  <cagney@redhat.com>

	* ns32k-tdep.c: Include "gdb_string.h".
	* mcore-tdep.c, cris-tdep.c, vax-tdep.c: Ditto.
	* sh3-rom.c, ppc-sysv-tdep.c, ns32knbsd-tdep.c: Ditto.
	* Makefile.in (sh3-rom.o): Update dependencies.
	(ppc-sysv-tdep.o, ns32k-tdep.o, mcore-tdep.o): Ditto.
	(cris-tdep.o): Ditto.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.257.2.4
diff -u -r1.257.2.4 Makefile.in
--- Makefile.in	9 Nov 2002 05:27:20 -0000	1.257.2.4
+++ Makefile.in	25 Nov 2002 22:04:37 -0000
@@ -1587,7 +1587,7 @@
 cris-tdep.o: cris-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(inferior_h) \
 	$(gdbtypes_h) $(gdbcore_h) $(gdbcmd_h) $(target_h) $(value_h) \
 	$(opcode_cris_h) $(arch_utils_h) $(regcache_h) $(symfile_h) \
-	$(solib_h) $(solib_svr4_h)
+	$(solib_h) $(solib_svr4_h) $(gdb_string_h)
 # OBSOLETE cxux-nat.o: cxux-nat.c
 d10v-tdep.o: d10v-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(gdbtypes_h) \
 	$(gdbcmd_h) $(gdbcore_h) $(gdb_string_h) $(value_h) $(inferior_h) \
@@ -1870,7 +1870,7 @@
 	$(gdb_string_h) $(regcache_h) $(serial_h)
 mcore-tdep.o: mcore-tdep.c $(defs_h) $(frame_h) $(symtab_h) $(value_h) \
 	$(gdbcmd_h) $(regcache_h) $(symfile_h) $(gdbcore_h) $(inferior_h) \
-	$(arch_utils_h)
+	$(arch_utils_h) $(gdb_string_h)
 mdebugread.o: mdebugread.c $(defs_h) $(symtab_h) $(gdbtypes_h) $(gdbcore_h) \
 	$(symfile_h) $(objfiles_h) $(gdb_obstack_h) $(buildsym_h) \
 	$(stabsread_h) $(complaints_h) $(demangle_h) $(gdb_assert_h) \
@@ -1923,10 +1923,10 @@
 	$(objfiles_h) $(buildsym_h) $(stabsread_h)
 ns32k-tdep.o: ns32k-tdep.c $(defs_h) $(frame_h) $(gdbtypes_h) $(gdbcore_h) \
 	$(inferior_h) $(regcache_h) $(target_h) $(arch_utils_h) \
-	$(ns32k_tdep_h)
+	$(ns32k_tdep_h) $(gdb_string_h)
 ns32knbsd-nat.o: ns32knbsd-nat.c $(defs_h) $(inferior_h) $(target_h) \
 	$(gdbcore_h) $(regcache_h)
-ns32knbsd-tdep.o: ns32knbsd-tdep.c $(defs_h) $(ns32k_tdep_h)
+ns32knbsd-tdep.o: ns32knbsd-tdep.c $(defs_h) $(ns32k_tdep_h) $(gdb_string_h)
 objfiles.o: objfiles.c $(defs_h) $(bfd_h) $(symtab_h) $(symfile_h) \
 	$(objfiles_h) $(gdb_stabs_h) $(target_h) $(bcache_h) $(gdb_stat_h) \
 	$(gdb_obstack_h) $(gdb_string_h) $(breakpoint_h) $(mmalloc_h)
@@ -1968,7 +1968,7 @@
 	$(symtab_h) $(target_h) $(gdbcore_h) $(gdbcmd_h) $(symfile_h) \
 	$(objfiles_h) $(regcache_h) $(value_h) $(solib_svr4_h) $(ppc_tdep_h)
 ppc-sysv-tdep.o: ppc-sysv-tdep.c $(defs_h) $(gdbcore_h) $(inferior_h) \
-	$(regcache_h) $(value_h) $(ppc_tdep_h)
+	$(regcache_h) $(value_h) $(ppc_tdep_h) $(gdb_string_h)
 ppcbug-rom.o: ppcbug-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \
 	$(serial_h) $(regcache_h)
 ppcnbsd-nat.o: ppcnbsd-nat.c $(defs_h) $(inferior_h) $(ppc_tdep_h) \
@@ -2103,7 +2103,8 @@
 	$(regcache_h) $(doublest_h) $(sh_tdep_h) $(elf_bfd_h) \
 	$(solib_svr4_h) $(elf_sh_h) $(gdb_sim_sh_h)
 sh3-rom.o: sh3-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \
-	$(serial_h) $(srec_h) $(arch_utils_h) $(regcache_h) $(sh_tdep_h)
+	$(serial_h) $(srec_h) $(arch_utils_h) $(regcache_h) $(sh_tdep_h) \
+	$(gdb_string_h)
 shnbsd-nat.o: shnbsd-nat.c $(defs_h) $(inferior_h) $(shnbsd_tdep_h)
 shnbsd-tdep.o: shnbsd-tdep.c $(defs_h) $(gdbcore_h) $(regcache_h) $(value_h) \
 	$(solib_svr4_h) $(nbsd_tdep_h) $(sh_tdep_h) $(shnbsd_tdep_h)
@@ -2251,7 +2252,7 @@
 	$(language_h) $(wrapper_h) $(gdbcmd_h) $(gdb_string_h) $(varobj_h)
 vax-tdep.o: vax-tdep.c $(defs_h) $(symtab_h) $(opcode_vax_h) $(gdbcore_h) \
 	$(inferior_h) $(regcache_h) $(frame_h) $(value_h) $(arch_utils_h) \
-	$(vax_tdep_h)
+	$(vax_tdep_h) $(gdb_string_h)
 w89k-rom.o: w89k-rom.c $(defs_h) $(gdbcore_h) $(target_h) $(monitor_h) \
 	$(serial_h) $(xmodem_h) $(regcache_h)
 win32-nat.o: win32-nat.c $(defs_h) $(tm_h) $(frame_h) $(inferior_h) \
Index: cris-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/cris-tdep.c,v
retrieving revision 1.21
diff -u -r1.21 cris-tdep.c
--- cris-tdep.c	24 Aug 2002 00:21:34 -0000	1.21
+++ cris-tdep.c	25 Nov 2002 22:04:38 -0000
@@ -31,6 +31,7 @@
 #include "opcode/cris.h"
 #include "arch-utils.h"
 #include "regcache.h"
+#include "gdb_string.h"
 
 /* To get entry_point_address.  */
 #include "symfile.h"
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.19
diff -u -r1.19 mcore-tdep.c
--- mcore-tdep.c	24 Aug 2002 00:21:35 -0000	1.19
+++ mcore-tdep.c	25 Nov 2002 22:04:39 -0000
@@ -27,6 +27,7 @@
 #include "gdbcore.h"
 #include "inferior.h"
 #include "arch-utils.h"
+#include "gdb_string.h"
 
 /* Functions declared and used only in this file */
 
Index: ns32k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v
retrieving revision 1.17
diff -u -r1.17 ns32k-tdep.c
--- ns32k-tdep.c	24 Aug 2002 00:21:35 -0000	1.17
+++ ns32k-tdep.c	25 Nov 2002 22:04:39 -0000
@@ -26,6 +26,7 @@
 #include "inferior.h"
 #include "regcache.h"
 #include "target.h"
+#include "gdb_string.h"
 
 #include "arch-utils.h"
 
Index: ns32knbsd-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ns32knbsd-tdep.c,v
retrieving revision 1.1
diff -u -r1.1 ns32knbsd-tdep.c
--- ns32knbsd-tdep.c	27 May 2002 01:05:16 -0000	1.1
+++ ns32knbsd-tdep.c	25 Nov 2002 22:04:39 -0000
@@ -22,6 +22,7 @@
 #include "defs.h"
 
 #include "ns32k-tdep.h"
+#include "gdb_string.h"
 
 static int
 ns32knbsd_aout_in_solib_call_trampoline (CORE_ADDR pc, char *name)
Index: ppc-sysv-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-sysv-tdep.c,v
retrieving revision 1.1
diff -u -r1.1 ppc-sysv-tdep.c
--- ppc-sysv-tdep.c	30 May 2002 01:21:51 -0000	1.1
+++ ppc-sysv-tdep.c	25 Nov 2002 22:04:39 -0000
@@ -25,6 +25,7 @@
 #include "inferior.h"
 #include "regcache.h"
 #include "value.h"
+#include "gdb_string.h"
 
 #include "ppc-tdep.h"
 
Index: sh3-rom.c
===================================================================
RCS file: /cvs/src/src/gdb/sh3-rom.c,v
retrieving revision 1.12
diff -u -r1.12 sh3-rom.c
--- sh3-rom.c	17 May 2002 06:55:48 -0000	1.12
+++ sh3-rom.c	25 Nov 2002 22:04:39 -0000
@@ -27,6 +27,7 @@
 #include "srec.h"
 #include "arch-utils.h"
 #include "regcache.h"
+#include "gdb_string.h"
 
 #include "sh-tdep.h"
 
Index: vax-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/vax-tdep.c,v
retrieving revision 1.18
diff -u -r1.18 vax-tdep.c
--- vax-tdep.c	24 Aug 2002 00:21:35 -0000	1.18
+++ vax-tdep.c	25 Nov 2002 22:04:40 -0000
@@ -28,6 +28,7 @@
 #include "frame.h"
 #include "value.h"
 #include "arch-utils.h"
+#include "gdb_string.h"
 
 #include "vax-tdep.h"
 

Re: [in/5.3] Fix some more build warnings

[David Carlton]

On Mon, 25 Nov 2002 17:07:34 -0500, Andrew Cagney <ac131313@redhat.com> said:

> I've checked this in to the 5.3 branch, an equivalent patch was
> committed to the mainline long ago.  Just that no one noticed :-/

You might also want to grab the remote-sds.c part of this:

2002-09-30  David Carlton  <carlton@math.stanford.edu>

	* Makefile.in (ppc-sysv-tdep.o): Depend on gdb_string_h.
	* ppc-sysv-tdep.c: #include "gdb_string.h".
	* remote-sds.c (getmessage): Add semicolon after 'retry' label to
	pacify GCC.

while you're at it.  It fixes a warning that recent GCC's generate but
older ones don't, so you might not be seeing it.  I'll include the
patch in question at the bottom of this message.  I don't think it's
particularly important, but if you want to get rid of all build
warnings, maybe it's a good idea.

David Carlton
carlton@math.stanford.edu

Index: remote-sds.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sds.c,v
retrieving revision 1.20
diff -u -p -r1.20 remote-sds.c
--- remote-sds.c	10 Feb 2002 04:08:42 -0000	1.20
+++ remote-sds.c	30 Sep 2002 18:45:17 -0000
@@ -978,6 +978,7 @@ getmessage (unsigned char *buf, int fore
       /* Try the whole thing again.  */
     retry:
       /* need to do something here */
+      ;
     }
 
   /* We have tried hard enough, and just can't receive the packet.  Give up. */