Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: David Carlton <carlton@math.stanford.edu>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [in/5.3] Fix some more build warnings
Date: Mon, 25 Nov 2002 14:14:00 -0000	[thread overview]
Message-ID: <ro1znrxb8l1.fsf@jackfruit.Stanford.EDU> (raw)
In-Reply-To: <3DE29F26.8070603@redhat.com>

On Mon, 25 Nov 2002 17:07:34 -0500, Andrew Cagney <ac131313@redhat.com> said:

> I've checked this in to the 5.3 branch, an equivalent patch was
> committed to the mainline long ago.  Just that no one noticed :-/

You might also want to grab the remote-sds.c part of this:

2002-09-30  David Carlton  <carlton@math.stanford.edu>

	* Makefile.in (ppc-sysv-tdep.o): Depend on gdb_string_h.
	* ppc-sysv-tdep.c: #include "gdb_string.h".
	* remote-sds.c (getmessage): Add semicolon after 'retry' label to
	pacify GCC.

while you're at it.  It fixes a warning that recent GCC's generate but
older ones don't, so you might not be seeing it.  I'll include the
patch in question at the bottom of this message.  I don't think it's
particularly important, but if you want to get rid of all build
warnings, maybe it's a good idea.

David Carlton
carlton@math.stanford.edu

Index: remote-sds.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sds.c,v
retrieving revision 1.20
diff -u -p -r1.20 remote-sds.c
--- remote-sds.c	10 Feb 2002 04:08:42 -0000	1.20
+++ remote-sds.c	30 Sep 2002 18:45:17 -0000
@@ -978,6 +978,7 @@ getmessage (unsigned char *buf, int fore
       /* Try the whole thing again.  */
     retry:
       /* need to do something here */
+      ;
     }
 
   /* We have tried hard enough, and just can't receive the packet.  Give up. */


      reply	other threads:[~2002-11-25 22:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-25 14:08 Andrew Cagney
2002-11-25 14:14 ` David Carlton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ro1znrxb8l1.fsf@jackfruit.Stanford.EDU \
    --to=carlton@math.stanford.edu \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox