From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 336 invoked by alias); 25 Nov 2002 22:14:44 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 327 invoked from network); 25 Nov 2002 22:14:44 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 25 Nov 2002 22:14:44 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id gAPMEat12567; Mon, 25 Nov 2002 14:14:36 -0800 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [in/5.3] Fix some more build warnings References: <3DE29F26.8070603@redhat.com> From: David Carlton Date: Mon, 25 Nov 2002 14:14:00 -0000 In-Reply-To: <3DE29F26.8070603@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-11/txt/msg00617.txt.bz2 On Mon, 25 Nov 2002 17:07:34 -0500, Andrew Cagney said: > I've checked this in to the 5.3 branch, an equivalent patch was > committed to the mainline long ago. Just that no one noticed :-/ You might also want to grab the remote-sds.c part of this: 2002-09-30 David Carlton * Makefile.in (ppc-sysv-tdep.o): Depend on gdb_string_h. * ppc-sysv-tdep.c: #include "gdb_string.h". * remote-sds.c (getmessage): Add semicolon after 'retry' label to pacify GCC. while you're at it. It fixes a warning that recent GCC's generate but older ones don't, so you might not be seeing it. I'll include the patch in question at the bottom of this message. I don't think it's particularly important, but if you want to get rid of all build warnings, maybe it's a good idea. David Carlton carlton@math.stanford.edu Index: remote-sds.c =================================================================== RCS file: /cvs/src/src/gdb/remote-sds.c,v retrieving revision 1.20 diff -u -p -r1.20 remote-sds.c --- remote-sds.c 10 Feb 2002 04:08:42 -0000 1.20 +++ remote-sds.c 30 Sep 2002 18:45:17 -0000 @@ -978,6 +978,7 @@ getmessage (unsigned char *buf, int fore /* Try the whole thing again. */ retry: /* need to do something here */ + ; } /* We have tried hard enough, and just can't receive the packet. Give up. */