From: Michael Snyder <msnyder@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com,
Fernando Nasser <fnasser@redhat.com>, cagney <cagney@redhat.com>
Subject: Re: [rfa/testsuite] Don't display values in output of pc-fp.exp
Date: Tue, 05 Nov 2002 14:17:00 -0000 [thread overview]
Message-ID: <3DC84357.95223AD3@redhat.com> (raw)
In-Reply-To: <ro1u1ivacl5.fsf@jackfruit.Stanford.EDU>
David Carlton wrote:
>
> The tests in pc-fp.exp display the actual values of $pc and $fp in
> their PASS messages. That makes regression testing a bit more
> annoying for me: the value of $fp changes with every change I make to
> GDB. Is it okay to tweak the PASS messages not to display those
> values?
>
> David Carlton
I'm not the maintainer, but the suggestion seems sound.
> carlton@math.stanford.edu
>
> 2002-11-05 David Carlton <carlton@math.stanford.edu>
>
> * gdb.base/pc-fp.exp (get_valueofx): Don't display 'val' in PASS
> message.
>
> Index: pc-fp.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
> retrieving revision 1.1
> diff -u -p -r1.1 pc-fp.exp
> --- pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
> +++ pc-fp.exp 5 Nov 2002 22:09:51 -0000
> @@ -62,7 +62,7 @@ proc get_valueofx { fmt exp default } {
> gdb_expect {
> -re "\\$\[0-9\]* = (0x\[0-9a-zA-Z\]+).*$gdb_prompt $" {
> set val $expect_out(1,string)
> - pass "get value of ${exp} ($val)"
> + pass "get value of ${exp}"
> }
> timeout {
> set size ${default}
next prev parent reply other threads:[~2002-11-05 22:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-05 14:14 David Carlton
2002-11-05 14:17 ` Michael Snyder [this message]
2002-11-05 14:54 ` Andrew Cagney
2002-11-05 15:11 ` David Carlton
2002-11-05 15:20 ` Andrew Cagney
2002-11-05 15:41 ` Andrew Cagney
[not found] ` <3DC98B56.2861A478@redhat.com>
2002-11-06 14:57 ` David Carlton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DC84357.95223AD3@redhat.com \
--to=msnyder@redhat.com \
--cc=cagney@redhat.com \
--cc=carlton@math.stanford.edu \
--cc=fnasser@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox